From: Andi Kleen <ak@suse.de>
To: Keith Owens <kaos@sgi.com>
Cc: linux-arch@vger.kernel.org, Paul Mackerras <paulus@au.ibm.com>,
Alan Stern <stern@rowland.harvard.edu>,
Hariprasad Nellitheertha <hari@in.ibm.com>,
Zwane Mwaikambo <zwane@linuxpower.ca>
Subject: Re: Replace i386/x86_64 nmi_callback RCU code with atomic notifier chain
Date: Thu, 18 May 2006 12:15:27 +0200 [thread overview]
Message-ID: <200605181215.28289.ak@suse.de> (raw)
In-Reply-To: <8256.1147933032@kao2.melbourne.sgi.com>
On Thursday 18 May 2006 08:17, Keith Owens wrote:
> i386 and x86_64 have low level RCU code to handle dynamic registration
> and unregistration of the NMI callback function. With the rewrite of
> the general notifier chains, we can remove the low level RCU hacking
> from these NMI handlers and replace them with an atomic notifier chain,
> making the code much simpler. set_nmi_callback() gets replaced by yet
> another notify chain. The only affected code outside the main NMI
> handler is crash and oprofile. Any objections?
It has been already done. Check -mm or firstfloor tree. However I don't
know if the module unload case is fully correct. If you find holes
feel free to submit patches for that.
But normally just for module unloading you don't need individual
RCU because the module unloader does a stop_machine() and that
blocks out most thing.
-Andi
next prev parent reply other threads:[~2006-05-18 11:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-18 6:17 Replace i386/x86_64 nmi_callback RCU code with atomic notifier chain Keith Owens
2006-05-18 10:15 ` Andi Kleen [this message]
2006-05-18 12:10 ` Keith Owens
2006-05-18 12:23 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200605181215.28289.ak@suse.de \
--to=ak@suse.de \
--cc=hari@in.ibm.com \
--cc=kaos@sgi.com \
--cc=linux-arch@vger.kernel.org \
--cc=paulus@au.ibm.com \
--cc=stern@rowland.harvard.edu \
--cc=zwane@linuxpower.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox