From: Paul Mundt <lethal@linux-sh.org>
To: James Bottomley <James.Bottomley@steeleye.com>
Cc: linux-arch@vger.kernel.org
Subject: Re: [PATCH] move scatterlist accessors into scatterlist.h on ia64, sh and sh64
Date: Thu, 25 May 2006 20:03:25 +0300 [thread overview]
Message-ID: <20060525170325.GB27601@linux-sh.org> (raw)
In-Reply-To: <1148221874.17239.3.camel@mulgrave.il.steeleye.com>
On Sun, May 21, 2006 at 09:31:14AM -0500, James Bottomley wrote:
> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
>
> ---
> Although this is a simple move, the sh implementation looks bogus.
> dma_map_sg is this:
>
[snip]
> which is about right for a simple physical==bus physical implementation.
> However, your accessor is:
>
> #define sg_dma_address(sg) (virt_to_bus((sg)->dma_address))
>
> so you're calling virt_to_bus() on an already physical address.
>
Yes, the virt_to_bus() is bogus, feel free to drop it. The rest looks
fine.
prev parent reply other threads:[~2006-05-25 17:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-21 14:31 [PATCH] move scatterlist accessors into scatterlist.h on ia64, sh and sh64 James Bottomley
2006-05-21 15:59 ` David Woodhouse
2006-05-21 16:14 ` James Bottomley
2006-05-21 16:16 ` David Woodhouse
2006-05-21 18:31 ` Chris Wedgwood
2006-05-25 17:03 ` Paul Mundt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060525170325.GB27601@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=James.Bottomley@steeleye.com \
--cc=linux-arch@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox