Re: [patch] s390 kconfig cleanup, 2nd version.

[Andi Kleen <ak@suse.de>]

On Friday 30 June 2006 15:28, Martin Schwidefsky wrote:
> On Fri, 2006-06-30 at 15:09 +0200, Andi Kleen wrote:
> > > > I must say I still hate the negative !S390. It would be much better
> > > > to define something positive. If PCI doesn't work maybe something 
> > > > else.
> > > 
> > > Well, I don't like these negative !S390 depends as well. But I can't
> > > help it, there is no other existing config symbol that can be used for a
> > > positive dependency. Hardware that is built into the machine and is not
> > > attached via some kind of bus does not have any dependency. 
> > 
> > 
> > But one can be invented. 
> > 
> > DESKTOP_HARDWARE
> > SMALL_IRON
> > END_USER_PCI
> > ...
> > 
> > Chose one.
> 
> None of them seems appropriate. The things the patch deactives for s390
> are vastly different (ATA/IDE, Parallel port, Plug and Play, I2C, I2O
> and so on). You will end up adding a lot of new config options. 

ATA/IDE, parallel port, PNP could be PC_STYLE_HARDWARE. 

I2O should be definitely PCI

I2C is an oddball. 

> > What stops users from plugging a PCI sound card into your PCI slots 
> > BTW?
> 
> Which PCI slot? s390 doesn't have PCI slots.

Ah I thought it had. If not you can just make most of that stuff
dependent on PCI, no?


-Andi