From: Adrian Bunk <bunk@stusta.de>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Valdis.Kletnieks@vt.edu, kai@germaschewski.name,
linux-kernel@vger.kernel.org, Dave Jones <davej@redhat.com>,
linux-arch@vger.kernel.org
Subject: Re: [2.6 patch] add -Werror-implicit-function-declaration to CFLAGS
Date: Fri, 7 Jul 2006 09:49:49 +0200 [thread overview]
Message-ID: <20060707074949.GB26941@stusta.de> (raw)
In-Reply-To: <20060707064218.GA29981@mars.ravnborg.org>
On Fri, Jul 07, 2006 at 08:42:18AM +0200, Sam Ravnborg wrote:
>...
> make -C /home/sam/kernel/kbuild.git O=/home/sam/kernel/osparc
> Using /home/sam/kernel/kbuild.git as source for kernel
> GEN /home/sam/kernel/osparc/Makefile
> CHK include/linux/version.h
> CHK include/linux/utsrelease.h
> CHK include/linux/compile.h
> CC arch/sparc/mm/init.o
> In file included from include2/asm/tlb.h:22,
> from /home/sam/kernel/kbuild.git/arch/sparc/mm/init.c:32:
> /home/sam/kernel/kbuild.git/include/asm-generic/tlb.h: In function `tlb_flush_mmu':
> /home/sam/kernel/kbuild.git/include/asm-generic/tlb.h:76: error: implicit declaration of function `release_pages'
> /home/sam/kernel/kbuild.git/include/asm-generic/tlb.h: In function `tlb_remove_page':
> /home/sam/kernel/kbuild.git/include/asm-generic/tlb.h:105: error: implicit declaration of function `page_cache_release'
> make[3]: *** [arch/sparc/mm/init.o] Error 1
> make[2]: *** [arch/sparc/mm] Error 2
> make[1]: *** [_all] Error 2
> make: *** [all] Error 2
>...
OK, I tried starting with this one.
The problem is that in the CONFIG_SWAP=n case, linux/swap.h uses these
functions.
These implicit declarations are bugs that should be fixed.
I tried adding an #include <linux/pagemap.h> to linux/swap.h, but this
broke things faster than I could fix them.
Does anyone know our header mess good enough for being able to help me
with this issue?
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2006-07-07 7:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20060706163728.GN26941@stusta.de>
2006-07-07 3:36 ` [2.6 patch] add -Werror-implicit-function-declaration to CFLAGS Sam Ravnborg
2006-07-07 5:02 ` Valdis.Kletnieks
2006-07-07 6:42 ` Sam Ravnborg
2006-07-07 7:49 ` Adrian Bunk [this message]
2006-07-07 7:18 ` Adrian Bunk
2006-07-07 7:49 ` Heiko Carstens
2006-07-07 9:33 ` Sam Ravnborg
2006-07-07 17:10 Luck, Tony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060707074949.GB26941@stusta.de \
--to=bunk@stusta.de \
--cc=Valdis.Kletnieks@vt.edu \
--cc=davej@redhat.com \
--cc=kai@germaschewski.name \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox