From: Sam Ravnborg <sam@ravnborg.org>
To: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: Adrian Bunk <bunk@stusta.de>,
kai@germaschewski.name, linux-kernel@vger.kernel.org,
Dave Jones <davej@redhat.com>,
linux-arch@vger.kernel.org
Subject: Re: [2.6 patch] add -Werror-implicit-function-declaration to CFLAGS
Date: Fri, 7 Jul 2006 11:33:31 +0200 [thread overview]
Message-ID: <20060707093331.GA25846@mars.ravnborg.org> (raw)
In-Reply-To: <20060707074918.GB9480@osiris.boeblingen.de.ibm.com>
On Fri, Jul 07, 2006 at 09:49:18AM +0200, Heiko Carstens wrote:
> > > Currently, using an undeclared function gives a compile warning, but it
> > > can lead to a nasty to debug runtime stack corruptions if the prototype
> > > of the function is different from what gcc guessed.
> > >
> > > With -Werror-implicit-function-declaration we are getting an immediate
> > > compile error instead.
> > This patch broke (-rc1):
> >
> > sparc allnoconfig build
> > ia64 allnoconfig build
> > ppc64 allnoconfig build
> >
> > x86_64 succeded an allnoconfig build
> >
> > I did not try other architectures. We need to fix the allnoconfig cases
> > at least for the popular architectures before applying this patch
> > otherwise it will create too much trouble/noise.
>
> s390 builds with defconfig and allnoconfig and a few other variants as well.
Thanks for testing.
Sam
next prev parent reply other threads:[~2006-07-07 9:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20060706163728.GN26941@stusta.de>
2006-07-07 3:36 ` [2.6 patch] add -Werror-implicit-function-declaration to CFLAGS Sam Ravnborg
2006-07-07 5:02 ` Valdis.Kletnieks
2006-07-07 6:42 ` Sam Ravnborg
2006-07-07 7:49 ` Adrian Bunk
2006-07-07 7:18 ` Adrian Bunk
2006-07-07 7:49 ` Heiko Carstens
2006-07-07 9:33 ` Sam Ravnborg [this message]
2006-07-07 17:10 Luck, Tony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060707093331.GA25846@mars.ravnborg.org \
--to=sam@ravnborg.org \
--cc=bunk@stusta.de \
--cc=davej@redhat.com \
--cc=heiko.carstens@de.ibm.com \
--cc=kai@germaschewski.name \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox