Re: [Kconfig] use disable command (was Re: [patch] s390 kconfig cleanup, 2nd version).

[Ralf Baechle <ralf@linux-mips.org>]

On Fri, Jul 07, 2006 at 01:48:43PM -0600, Matthew Wilcox wrote:

>  config RTC
>         tristate "Enhanced Real Time Clock Support"
> -       depends on !PPC && !PARISC && !IA64 && !M68K && (!SPARC || PCI) && !FRV && !ARM
> +       depends on ALPHA || CRIS || H8300 || X86 || M32R || MIPS || SUPERH || (SPARC && PCI) || V850
> 
> (I suspect CRIS, H8300, V850 and M32R should not be in this list.
> Presumably the maintainers are on this list; could they comment?)

Making this depend on the CPU is grosly simplifying things - and wrong.  On
MIPS the MC146818 is used in several systems but not all and chances are
the driver will crash the system if selected on some of the systems.  So
in the end I would suggeste something like in drivers/char/Kconfig:

config RTC
	tristate "Enhanced Real Time Clock Support"
	depends on SYS_HAS_MC146818

config SYS_HAS_MC146818
	bool

and somewhere from arch/*/Kconfig SYS_HAS_MC146818 will have to be selected.

The other rant of course is that the symbol CONFIG_RTC looks like it is
generic RTC support while it really only is for MC146818 and lookalikes.
So it should be renamed to something like CONFIG_MC146818.

  Ralf