From: Matthew Wilcox <matthew@wil.cx>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Andrew Morton <akpm@osdl.org>, Linus Torvalds <torvalds@osdl.org>,
mingo@elte.hu, linux-arch@vger.kernel.org,
David Howells <dhowells@redhat.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 01/02] remove set_wmb - doc update
Date: Fri, 14 Jul 2006 20:22:33 -0600 [thread overview]
Message-ID: <20060715022233.GA1578@parisc-linux.org> (raw)
In-Reply-To: <1152907501.27135.44.camel@localhost.localdomain>
On Fri, Jul 14, 2006 at 04:05:01PM -0400, Steven Rostedt wrote:
> There are some more advanced barrier functions:
>
> (*) set_mb(var, value)
> - (*) set_wmb(var, value)
>
> - These assign the value to the variable and then insert at least a write
> - barrier after it, depending on the function. They aren't guaranteed to
> + This assigns the value to the variable and then inserts at least a write
> + barrier after it, depending on the function. It isn't guaranteed to
> insert anything more than a compiler barrier in a UP compilation.
"There is one more advanced barrier function"? ;-) Or did you want to
remove set_mb()?
Plus, the "depending on the function" bit means "respectively". So what
you really want as help is something like:
This assigns the value to the variable and then inserts a
barrier after the assignment. It isn't guaranteed to insert
anything more than a compiler barrier in a UP compilation.
next prev parent reply other threads:[~2006-07-15 2:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1152882288.1883.30.camel@localhost.localdomain>
[not found] ` <Pine.LNX.4.64.0607140757080.5623@g5.osdl.org>
[not found] ` <Pine.LNX.4.64.0607141017520.5623@g5.osdl.org>
[not found] ` <1152898699.27135.20.camel@localhost.localdomain>
[not found] ` <Pine.LNX.4.64.0607141040550.5623@g5.osdl.org>
[not found] ` <20060714105841.4490c0e2.akpm@osdl.org>
2006-07-14 20:04 ` [PATCH 00/02] remove set_wmb Steven Rostedt
2006-07-14 20:05 ` [PATCH 01/02] remove set_wmb - doc update Steven Rostedt
2006-07-15 2:22 ` Matthew Wilcox [this message]
2006-07-15 2:35 ` Steven Rostedt
2006-07-14 20:05 ` [PATCH 02/02] remove set_wmb - arch removal Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060715022233.GA1578@parisc-linux.org \
--to=matthew@wil.cx \
--cc=akpm@osdl.org \
--cc=dhowells@redhat.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox