Re: module compiler version check still needed?

Adrian Bunk
2006-08-13T22:04:34Z

On Sun, Aug 13, 2006 at 10:27:24PM +0200, Andi Kleen wrote:
> On Sunday 13 August 2006 06:59, Keith Owens wrote:
> > Andi Kleen (on Sun, 13 Aug 2006 06:48:36 +0200) wrote:
> > >
> > >Does anybody know of any reason why we would still need the compiler version
> > >check during module loading? AFAIK on i386 it was only needed to handle
> > >2.95 (which got dropped) and on x86-64 it was never needed. Is there
> > >a need on any other architecture for it?
> >
> > IA64 still needs the check. include/asm-ia64/spinlock.h generates
> > different calls to the out of line spinlock handler, depending on the
> > version of gcc.
>
> Thanks. But I guess it could be used to MODULE_ARCH_VERMAGIC for ia64 only then.
> If nobody else complains I will do that.

People might not complain until this is for some time in a released
kernel.

Why don't you check yourself?

grep -r __GNUC__ *
grep -r cc-version *

There are over 100 results, but it's easy to spot the few requiring a
deeper look.

> -Andi

cu
Adrian

--

Gentoo kernels are 42 times more popular than SUSE kernels among
KLive users (a service by SUSE contractor Andrea Arcangeli that
gathers data about kernels from many users worldwide).

There are three kinds of lies: Lies, Damn Lies, and Statistics.
Benjamin Disraeli