public inbox for linux-arch@vger.kernel.org
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: torvalds@osdl.org, akpm@osdl.org
Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
	dhowells@redhat.com
Subject: [PATCH 6/6] Alter roundup_pow_of_two() so that it can make use of long_log2() on a constant
Date: Wed, 13 Sep 2006 14:03:04 +0100	[thread overview]
Message-ID: <20060913130304.32022.10732.stgit@warthog.cambridge.redhat.com> (raw)
In-Reply-To: <20060913130253.32022.69230.stgit@warthog.cambridge.redhat.com>

From: David Howells <dhowells@redhat.com>

Alter roundup_pow_of_two() so that it can make use of long_log2() on a constant
to produce a constant value, retaining the ability for an arch to override it
in the non-const case.

This permits the function to be used to initialise variables.

Signed-Off-By: David Howells <dhowells@redhat.com>
---

 include/linux/kernel.h |    6 ------
 include/linux/log2.h   |   23 +++++++++++++++++++++++
 2 files changed, 23 insertions(+), 6 deletions(-)

diff --git a/include/linux/kernel.h b/include/linux/kernel.h
index e8c6c66..e5947fb 100644
--- a/include/linux/kernel.h
+++ b/include/linux/kernel.h
@@ -155,12 +155,6 @@ #endif
 
 unsigned long int_sqrt(unsigned long);
 
-static inline unsigned long
-__attribute_const__ roundup_pow_of_two(unsigned long x)
-{
-	return 1UL << fls_long(x - 1);
-}
-
 extern int printk_ratelimit(void);
 extern int __printk_ratelimit(int ratelimit_jiffies, int ratelimit_burst);
 
diff --git a/include/linux/log2.h b/include/linux/log2.h
index a2f6858..2b55af0 100644
--- a/include/linux/log2.h
+++ b/include/linux/log2.h
@@ -74,6 +74,15 @@ #endif
 #endif
 
 /*
+ * round up to nearest power of two
+ */
+static inline __attribute__((const))
+unsigned long __roundup_pow_of_two(unsigned long n)
+{
+	return 1UL << fls_long(n - 1);
+}
+
+/*
  * constant-capable 32-bit log of base 2 calculation
  * - this can be used to initialise global variables from constant data, hence
  *   the massive ternary operator construction
@@ -218,4 +227,18 @@ (									\
 	__get_order(n, PAGE_SHIFT)					\
  )
 
+/*
+ * round up to nearest power of two
+ * - the result is undefined when n == 0
+ * - this can be used to initialise global variables from constant data
+ */
+#define roundup_pow_of_two(n)				\
+(							\
+	__builtin_constant_p(n) ? (			\
+		(n == 1) ? 0 :				\
+		(1UL << (long_log2((n) - 1) + 1))	\
+				   ) :			\
+	__roundup_pow_of_two(n)				\
+ )
+
 #endif /* _LINUX_LOG2_H */

      parent reply	other threads:[~2006-09-13 13:03 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-13 13:02 [PATCH 1/6] FRV: Fix fls() to handle bit 31 being set correctly David Howells
2006-09-13 13:02 ` [PATCH 2/6] FRV: Implement fls64() David Howells
2006-09-13 13:02 ` [PATCH 3/6] FRV: Optimise ffs() David Howells
2006-09-13 13:03 ` [PATCH 4/6] Implement a general log2 facility in the kernel David Howells
2006-09-13 15:57   ` Luck, Tony
2006-09-13 16:50     ` David Howells
2006-09-13 16:17   ` Adrian Bunk
2006-09-13 16:31     ` Matthew Wilcox
2006-09-13 16:38       ` Russell King
2006-09-13 16:56         ` David Howells
2006-09-13 18:38           ` Geert Uytterhoeven
2006-09-13 18:45             ` Russell King
2006-09-13 19:09               ` Geert Uytterhoeven
2006-09-13 13:03 ` [PATCH 5/6] Alter get_order() so that it can make use of long_log2() on a constant David Howells
2006-09-13 13:03 ` David Howells [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060913130304.32022.10732.stgit@warthog.cambridge.redhat.com \
    --to=dhowells@redhat.com \
    --cc=akpm@osdl.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox