Re: [PATCH 4/6] Implement a general log2 facility in the kernel

Geert Uytterhoeven
2006-09-13T19:09:22Z

On Wed, 13 Sep 2006, Russell King wrote:
> On Wed, Sep 13, 2006 at 08:38:59PM +0200, Geert Uytterhoeven wrote:
> > On Wed, 13 Sep 2006, David Howells wrote:
> > > Russell King <rmk+lkml@arm.linux.org.uk> wrote:
> > >
> > > > Therefore, re-using "log2()" is about as bad as re-using the "strcmp()"
> > > > name to implement a function which copies strings.
> > >
> > > I should probably use ilog2() then which would at least be consistent with the
> > > powerpc arch.
> > >
> > > > t.c:2: warning: conflicting types for built-in function 'log2'
> >
> > And apparently gcc < 4.0 doesn't give the warning.
>
> Eh? That's gcc 3.4.3 producing that warning. It probably depends on
> the target configuration.

I have to admit I didn't try all versions. So < 4.0 was a guess, based on the
(Debian) versions I have installed on my laptop...

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds