Re: [PATCH 4/6] Implement a general log2 facility in the kernel

David Howells
2006-09-13T16:58:38Z

Russell King <rmk+lkml@arm.linux.org.uk> wrote:

> Therefore, re-using "log2()" is about as bad as re-using the "strcmp()"
> name to implement a function which copies strings.

I should probably use ilog2() then which would at least be consistent with the
powerpc arch.

> t.c:2: warning: conflicting types for built-in function 'log2'

Which, of course, I didn't see because I didn't define it as a function,
merely as a macro.

David