Re: [PATCH 4/6] Implement a general log2 facility in the kernel

Matthew Wilcox
2006-09-13T16:31:38Z

On Wed, Sep 13, 2006 at 06:17:34PM +0200, Adrian Bunk wrote:
> On Wed, Sep 13, 2006 at 02:03:00PM +0100, David Howells wrote:
> > From: David Howells <dhowells@redhat.com>
> >
> > This facility provides three entry points:
> >
> > log2() Log base 2 of u32
> >...
>
> Considering that several arch maintainers have vetoed my patch to revert
> the -ffreestanding removal Andi sneaked in with his usual trick to hide
> generic patches as "x86_64 patch", such a usage of a libc function name
> with a signature different from the one defined in ISO/IEC 9899:1999 is
> a namespace violation that mustn't happen.

log2 is only defined if math.h gets included. If we're including math.h
at any point in the kernel itself (excluding the bootloader and similar),
we're already screwed six ways from sunday.