From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: David Howells <dhowells@redhat.com>,
Matthew Wilcox <matthew@wil.cx>, Adrian Bunk <bunk@stusta.de>,
Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>,
Linux Kernel Development <linux-kernel@vger.kernel.org>,
linux-arch@vger.kernel.org
Subject: Re: [PATCH 4/6] Implement a general log2 facility in the kernel
Date: Wed, 13 Sep 2006 19:45:58 +0100 [thread overview]
Message-ID: <20060913184558.GB15563@flint.arm.linux.org.uk> (raw)
In-Reply-To: <Pine.LNX.4.62.0609132038350.27940@pademelon.sonytel.be>
On Wed, Sep 13, 2006 at 08:38:59PM +0200, Geert Uytterhoeven wrote:
> On Wed, 13 Sep 2006, David Howells wrote:
> > Russell King <rmk+lkml@arm.linux.org.uk> wrote:
> >
> > > Therefore, re-using "log2()" is about as bad as re-using the "strcmp()"
> > > name to implement a function which copies strings.
> >
> > I should probably use ilog2() then which would at least be consistent with the
> > powerpc arch.
> >
> > > t.c:2: warning: conflicting types for built-in function 'log2'
>
> And apparently gcc < 4.0 doesn't give the warning.
Eh? That's gcc 3.4.3 producing that warning. It probably depends on
the target configuration.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
next prev parent reply other threads:[~2006-09-13 18:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-13 13:02 [PATCH 1/6] FRV: Fix fls() to handle bit 31 being set correctly David Howells
2006-09-13 13:02 ` [PATCH 2/6] FRV: Implement fls64() David Howells
2006-09-13 13:02 ` [PATCH 3/6] FRV: Optimise ffs() David Howells
2006-09-13 13:03 ` [PATCH 4/6] Implement a general log2 facility in the kernel David Howells
2006-09-13 15:57 ` Luck, Tony
2006-09-13 16:50 ` David Howells
2006-09-13 16:17 ` Adrian Bunk
2006-09-13 16:31 ` Matthew Wilcox
2006-09-13 16:38 ` Russell King
2006-09-13 16:56 ` David Howells
2006-09-13 18:38 ` Geert Uytterhoeven
2006-09-13 18:45 ` Russell King [this message]
2006-09-13 19:09 ` Geert Uytterhoeven
2006-09-13 13:03 ` [PATCH 5/6] Alter get_order() so that it can make use of long_log2() on a constant David Howells
2006-09-13 13:03 ` [PATCH 6/6] Alter roundup_pow_of_two() " David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060913184558.GB15563@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=akpm@osdl.org \
--cc=bunk@stusta.de \
--cc=dhowells@redhat.com \
--cc=geert@linux-m68k.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox