From: Matthew Wilcox <matthew@wil.cx>
To: Jeff Garzik <jeff@garzik.org>
Cc: Linus Torvalds <torvalds@osdl.org>,
linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Use linux/io.h instead of asm/io.h
Date: Thu, 5 Oct 2006 11:26:11 -0600 [thread overview]
Message-ID: <20061005172611.GB2563@parisc-linux.org> (raw)
In-Reply-To: <45253EAE.2070600@garzik.org>
On Thu, Oct 05, 2006 at 01:19:42PM -0400, Jeff Garzik wrote:
> Matthew Wilcox wrote:
> >In preparation for moving check_signature, change these users from
> >asm/io.h to linux/io.h
>
> The vast majority of drivers include asm/io.h.
Yes. linux/io.h was only created recently. It's proper style to
include linux/foo.h when both linux/foo.h and asm/foo.h exist [1]
This is just a transition which hasn't been completed yet (indeed, has
barely begun).
> Wouldn't it be better to move check_signature to
> include/asm-generic/io.h, and include that where needed?
I really don't think that proliferating header files unnecessarily is a
good idea.
[1] Except, of course, <linux/irq.h>, but I thought rmk was going to fix
that.
next prev parent reply other threads:[~2006-10-05 17:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-05 17:05 [PATCH] Use linux/io.h instead of asm/io.h Matthew Wilcox
2006-10-05 17:05 ` [PATCH] Consolidate check_signature Matthew Wilcox
2006-10-05 17:20 ` Jeff Garzik
2006-10-08 20:21 ` Andrew Morton
2006-10-08 20:24 ` Al Viro
2006-10-05 17:19 ` [PATCH] Use linux/io.h instead of asm/io.h Jeff Garzik
2006-10-05 17:26 ` Matthew Wilcox [this message]
2006-10-05 22:04 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061005172611.GB2563@parisc-linux.org \
--to=matthew@wil.cx \
--cc=jeff@garzik.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).