From: David Howells <dhowells@redhat.com>
To: torvalds@osdl.org, akpm@osdl.org, sfr@canb.auug.org.au
Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
dhowells@redhat.com
Subject: [PATCH 4/4] LOG2: Provide ilog2() fallbacks for powerpc [try #4]
Date: Fri, 06 Oct 2006 14:34:22 +0100 [thread overview]
Message-ID: <20061006133422.9972.29416.stgit@warthog.cambridge.redhat.com> (raw)
In-Reply-To: <20061006133414.9972.79007.stgit@warthog.cambridge.redhat.com>
From: David Howells <dhowells@redhat.com>
Provide ilog2() fallbacks for powerpc for 32-bit numbers and 64-bit numbers on
ppc64.
Signed-Off-By: David Howells <dhowells@redhat.com>
---
arch/powerpc/Kconfig | 4 ++--
include/asm-powerpc/bitops.h | 21 ++++++++++++++++++++-
include/asm-powerpc/page_32.h | 10 +---------
3 files changed, 23 insertions(+), 12 deletions(-)
diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
index 1cf67b7..9515489 100644
--- a/arch/powerpc/Kconfig
+++ b/arch/powerpc/Kconfig
@@ -43,11 +43,11 @@ config RWSEM_XCHGADD_ALGORITHM
config ARCH_HAS_ILOG2_U32
bool
- default n
+ default y
config ARCH_HAS_ILOG2_U64
bool
- default n
+ default y if 64BIT
config GENERIC_HWEIGHT
bool
diff --git a/include/asm-powerpc/bitops.h b/include/asm-powerpc/bitops.h
index c341063..0288144 100644
--- a/include/asm-powerpc/bitops.h
+++ b/include/asm-powerpc/bitops.h
@@ -190,7 +190,8 @@ #include <asm-generic/bitops/non-atomic.
* Return the zero-based bit position (LE, not IBM bit numbering) of
* the most significant 1-bit in a double word.
*/
-static __inline__ int __ilog2(unsigned long x)
+static __inline__ __attribute__((const))
+int __ilog2(unsigned long x)
{
int lz;
@@ -198,6 +199,24 @@ static __inline__ int __ilog2(unsigned l
return BITS_PER_LONG - 1 - lz;
}
+static inline __attribute__((const))
+int __ilog2_u32(u32 n)
+{
+ int bit;
+ asm ("cntlzw %0,%1" : "=r" (bit) : "r" (n));
+ return 31 - bit;
+}
+
+#ifdef __powerpc64__
+static inline __attribute__((const))
+int __ilog2_u64(u32 n)
+{
+ int bit;
+ asm ("cntlzd %0,%1" : "=r" (bit) : "r" (n));
+ return 63 - bit;
+}
+#endif
+
/*
* Determines the bit position of the least significant 0 bit in the
* specified double word. The returned bit position will be
diff --git a/include/asm-powerpc/page_32.h b/include/asm-powerpc/page_32.h
index 2677bad..07f6d3c 100644
--- a/include/asm-powerpc/page_32.h
+++ b/include/asm-powerpc/page_32.h
@@ -26,15 +26,7 @@ extern void clear_pages(void *page, int
static inline void clear_page(void *page) { clear_pages(page, 0); }
extern void copy_page(void *to, void *from);
-/* Pure 2^n version of get_order */
-extern __inline__ int get_order(unsigned long size)
-{
- int lz;
-
- size = (size-1) >> PAGE_SHIFT;
- asm ("cntlzw %0,%1" : "=r" (lz) : "r" (size));
- return 32 - lz;
-}
+#include <asm-generic/page.h>
#endif /* __ASSEMBLY__ */
next prev parent reply other threads:[~2006-10-06 13:34 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-06 13:34 [PATCH 1/4] LOG2: Implement a general integer log2 facility in the kernel [try #4] David Howells
2006-10-06 13:34 ` [PATCH 2/4] LOG2: Alter roundup_pow_of_two() so that it can use a ilog2() on a constant " David Howells
2006-10-06 13:34 ` [PATCH 3/4] LOG2: Alter get_order() so that it can make use of " David Howells
2006-10-06 13:34 ` David Howells [this message]
2006-10-06 14:17 ` [PATCH 1/4] LOG2: Implement a general integer log2 facility in the kernel " Matthew Wilcox
2006-10-06 14:33 ` David Howells
2006-10-06 17:17 ` Christoph Lameter
2006-10-09 10:11 ` David Howells
2006-10-09 11:06 ` Christoph Lameter
2006-10-09 12:09 ` David Howells
2006-10-09 17:17 ` Christoph Lameter
2006-10-10 9:58 ` David Howells
2006-10-06 20:33 ` Jan Engelhardt
2006-10-06 20:39 ` Matthew Wilcox
2006-10-06 20:52 ` Jan Engelhardt
2006-10-09 8:06 ` David Howells
2006-10-09 8:36 ` Jan Engelhardt
2006-10-09 9:51 ` Kyle Moffett
2006-10-09 10:26 ` Arnd Bergmann
2006-10-09 10:32 ` Stephen Rothwell
2006-10-09 12:20 ` Jan Engelhardt
2006-10-09 12:54 ` David Howells
2006-10-09 20:00 ` Jan Engelhardt
2006-10-09 20:36 ` Andreas Schwab
2006-10-10 9:41 ` Jan Engelhardt
2006-10-10 11:42 ` Arnd Bergmann
2006-10-09 13:09 ` Geert Uytterhoeven
2006-10-09 14:52 ` Arnd Bergmann
2006-10-09 15:05 ` Geert Uytterhoeven
2006-10-09 15:27 ` Arnd Bergmann
2006-10-09 15:31 ` Geert Uytterhoeven
2006-10-09 16:47 ` Arnd Bergmann
2006-10-10 7:55 ` David Woodhouse
2006-10-10 12:12 ` Arnd Bergmann
2006-10-10 12:23 ` David Howells
2006-10-07 23:50 ` Roman Zippel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061006133422.9972.29416.stgit@warthog.cambridge.redhat.com \
--to=dhowells@redhat.com \
--cc=akpm@osdl.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox