From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from zeniv.linux.org.uk ([195.92.253.2]:8910 "EHLO ZenIV.linux.org.uk") by vger.kernel.org with ESMTP id S1751450AbWJHUY1 (ORCPT ); Sun, 8 Oct 2006 16:24:27 -0400 Date: Sun, 8 Oct 2006 21:24:24 +0100 From: Al Viro Subject: Re: [PATCH] Consolidate check_signature Message-ID: <20061008202423.GC29920@ftp.linux.org.uk> References: <11600679551209-git-send-email-matthew@wil.cx> <11600679552794-git-send-email-matthew@wil.cx> <20061008132147.958dc6a8.akpm@osdl.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20061008132147.958dc6a8.akpm@osdl.org> Sender: linux-arch-owner@vger.kernel.org To: Andrew Morton Cc: Matthew Wilcox , Linus Torvalds , linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Matthew Wilcox List-ID: On Sun, Oct 08, 2006 at 01:21:47PM -0700, Andrew Morton wrote: > On Thu, 05 Oct 2006 11:05:55 -0600 > Matthew Wilcox wrote: > > > There's nothing arch-specific about check_signature(), so move it to > > . Use a cross between the Alpha and i386 implementations > > as the generic one. > > It wuld have been nice to have uninlined it too. And to have given > it a less crappy name. memcmp_withio(), to follow the general style?