Re: [PATCH 1/4] LOG2: Implement a general integer log2 facility in the kernel [try #4]

Jan Engelhardt
2006-10-06T20:58:42Z

>> >+ * the massive ternary operator construction
>> >+ (sizeof(n) <= 4) ? \
>> >+ __ilog2_u32(n) : \
>> >+ __ilog2_u64(n) \
>>
>> Should not this be: sizeof(n) <= sizeof(u32)
>
>Were you planning on porting Linux to a machine with non-8-bit-bytes any
>time soon? Because there's a lot more to fix than this.

I am considering the case [assuming 8-bit-byte machines] where
sizeof(u32) is not 4. Though I suppose GCC will probably make a 32-bit
type up if the hardware does not know one.

-`J'
--