Re: [PATCH 1/4] LOG2: Implement a general integer log2 facility in the kernel [try #4]

Matthew Wilcox
2006-10-06T20:39:20Z

On Fri, Oct 06, 2006 at 10:33:19PM +0200, Jan Engelhardt wrote:
>
> >+ * the massive ternary operator construction
> >+ (sizeof(n) <= 4) ? \
> >+ __ilog2_u32(n) : \
> >+ __ilog2_u64(n) \
>
> Should not this be: sizeof(n) <= sizeof(u32)

Were you planning on porting Linux to a machine with non-8-bit-bytes any
time soon? Because there's a lot more to fix than this.