From: Arnd Bergmann <arnd.bergmann@de.ibm.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Jan Engelhardt <jengelh@linux01.gwdg.de>,
Kyle Moffett <mrmacman_g4@mac.com>,
David Howells <dhowells@redhat.com>,
Matthew Wilcox <matthew@wil.cx>,
Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>,
sfr@canb.auug.org.au,
Linux Kernel Development <linux-kernel@vger.kernel.org>,
linux-arch@vger.kernel.org
Subject: Re: [PATCH 1/4] LOG2: Implement a general integer log2 facility in the kernel [try #4]
Date: Mon, 9 Oct 2006 17:27:32 +0200 [thread overview]
Message-ID: <200610091727.34780.arnd.bergmann@de.ibm.com> (raw)
In-Reply-To: <Pine.LNX.4.62.0610091705070.16048@pademelon.sonytel.be>
On Monday 09 October 2006 17:05, Geert Uytterhoeven wrote:
>
> On Mon, 9 Oct 2006, Arnd Bergmann wrote:
> > On Monday 09 October 2006 15:09, Geert Uytterhoeven wrote:
> > > On Mon, 9 Oct 2006, Jan Engelhardt wrote:
> > > >
> > > > Ouch ouch ouch. It should better be
> > > >
> > > > typedef uint32_t __u32;
> > >
> > > You mean
> > >
> > > #ifdef __KERNEL__
> > > typedef __u32 u32;
> > > #else
> > > // Assumed we did #include <stdint.h> before
> > > typedef uint32_t __u32;
> > > #endif
> >
> > Why should that be a valid assumption? Right now, it works
> > if you don't include stdint.h in advance.
>
> According to C99 section 7.18 you need to include <stdint.h> first.
Sorry, I need to rephrase: you can include <linux/types.h> without
including <stdint.h> first, and many people do that.
Relying on uint32_t would mean we break existing source.
Arnd <><
next prev parent reply other threads:[~2006-10-09 15:27 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-06 13:34 [PATCH 1/4] LOG2: Implement a general integer log2 facility in the kernel [try #4] David Howells
2006-10-06 13:34 ` [PATCH 2/4] LOG2: Alter roundup_pow_of_two() so that it can use a ilog2() on a constant " David Howells
2006-10-06 13:34 ` [PATCH 3/4] LOG2: Alter get_order() so that it can make use of " David Howells
2006-10-06 13:34 ` [PATCH 4/4] LOG2: Provide ilog2() fallbacks for powerpc " David Howells
2006-10-06 14:17 ` [PATCH 1/4] LOG2: Implement a general integer log2 facility in the kernel " Matthew Wilcox
2006-10-06 14:33 ` David Howells
2006-10-06 17:17 ` Christoph Lameter
2006-10-09 10:11 ` David Howells
2006-10-09 11:06 ` Christoph Lameter
2006-10-09 12:09 ` David Howells
2006-10-09 17:17 ` Christoph Lameter
2006-10-10 9:58 ` David Howells
2006-10-06 20:33 ` Jan Engelhardt
2006-10-06 20:39 ` Matthew Wilcox
2006-10-06 20:52 ` Jan Engelhardt
2006-10-09 8:06 ` David Howells
2006-10-09 8:36 ` Jan Engelhardt
2006-10-09 9:51 ` Kyle Moffett
2006-10-09 10:26 ` Arnd Bergmann
2006-10-09 10:32 ` Stephen Rothwell
2006-10-09 12:20 ` Jan Engelhardt
2006-10-09 12:54 ` David Howells
2006-10-09 20:00 ` Jan Engelhardt
2006-10-09 20:36 ` Andreas Schwab
2006-10-10 9:41 ` Jan Engelhardt
2006-10-10 11:42 ` Arnd Bergmann
2006-10-09 13:09 ` Geert Uytterhoeven
2006-10-09 14:52 ` Arnd Bergmann
2006-10-09 15:05 ` Geert Uytterhoeven
2006-10-09 15:27 ` Arnd Bergmann [this message]
2006-10-09 15:31 ` Geert Uytterhoeven
2006-10-09 16:47 ` Arnd Bergmann
2006-10-10 7:55 ` David Woodhouse
2006-10-10 12:12 ` Arnd Bergmann
2006-10-10 12:23 ` David Howells
2006-10-07 23:50 ` Roman Zippel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200610091727.34780.arnd.bergmann@de.ibm.com \
--to=arnd.bergmann@de.ibm.com \
--cc=akpm@osdl.org \
--cc=dhowells@redhat.com \
--cc=geert@linux-m68k.org \
--cc=jengelh@linux01.gwdg.de \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=mrmacman_g4@mac.com \
--cc=sfr@canb.auug.org.au \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox