From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e5.ny.us.ibm.com ([32.97.182.145]:32951 "EHLO e5.ny.us.ibm.com") by vger.kernel.org with ESMTP id S932933AbWJIP1j (ORCPT ); Mon, 9 Oct 2006 11:27:39 -0400 From: Arnd Bergmann Subject: Re: [PATCH 1/4] LOG2: Implement a general integer log2 facility in the kernel [try #4] Date: Mon, 9 Oct 2006 17:27:32 +0200 References: <200610091652.26209.arnd.bergmann@de.ibm.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200610091727.34780.arnd.bergmann@de.ibm.com> Sender: linux-arch-owner@vger.kernel.org To: Geert Uytterhoeven Cc: Jan Engelhardt , Kyle Moffett , David Howells , Matthew Wilcox , Linus Torvalds , Andrew Morton , sfr@canb.auug.org.au, Linux Kernel Development , linux-arch@vger.kernel.org List-ID: On Monday 09 October 2006 17:05, Geert Uytterhoeven wrote: > > On Mon, 9 Oct 2006, Arnd Bergmann wrote: > > On Monday 09 October 2006 15:09, Geert Uytterhoeven wrote: > > > On Mon, 9 Oct 2006, Jan Engelhardt wrote: > > > > > > > > Ouch ouch ouch. It should better be > > > > > > > > typedef uint32_t __u32; > > > > > > You mean > > > > > > #ifdef __KERNEL__ > > > typedef __u32 u32; > > > #else > > > // Assumed we did #include before > > > typedef uint32_t __u32; > > > #endif > > > > Why should that be a valid assumption? Right now, it works > > if you don't include stdint.h in advance. > > According to C99 section 7.18 you need to include first. Sorry, I need to rephrase: you can include without including first, and many people do that. Relying on uint32_t would mean we break existing source. Arnd <><