From: Andrew Morton <akpm@osdl.org>
To: Kyle McMartin <kyle@parisc-linux.org>
Cc: linux-arch@vger.kernel.org
Subject: Re: Generic compat_sys_rt_sigqueueinfo
Date: Mon, 30 Oct 2006 23:02:10 -0800 [thread overview]
Message-ID: <20061030230210.041531ea.akpm@osdl.org> (raw)
In-Reply-To: <20061030155910.GC13625@athena.road.mcmartin.ca>
On Mon, 30 Oct 2006 10:59:10 -0500
Kyle McMartin <kyle@parisc-linux.org> wrote:
> Every 32-on-64 arch (except parisc) was implementing effectively the
> same sys32_rt_sigqueueinfo. Add a generic implementation taken from
> x86_64 and add it to kernel/compat.c, which required the addition of
> copy_siginfo_from_user32 on mips and powerpc. sparc64 had a sufficient
> implementation for this purpose, so crib it for both those platforms.
>
> This yields a nice clean up and is one step towards cleaning up some
> of the compat signals mess parisc has been carrying out of tree for a few
> years.
>
> Incorporated Arnd's suggestion of not bothering to call sys_rt_sigqueueinfo
> and just doing the full syscall in compat_sys_rt_sigqueueinfo.
>
> Signed-off-by: Kyle McMartin <kyle@parisc-linux.org>
> --
> [N.B. the modification to powerpc is probably wrong, since it seems
> to require a wrapper for handling the signed ints like sparc64 and s390
> have. -- Kyle]
Well that's a bit sad. Could the ppc guys please take a look?
Thanks.
next prev parent reply other threads:[~2006-10-31 7:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-28 22:37 Generic compat_sys_rt_sigqueueinfo Kyle McMartin
2006-10-28 22:47 ` Matthew Wilcox
2006-10-28 22:53 ` Kyle McMartin
2006-10-28 23:09 ` Matthew Wilcox
2006-10-28 23:09 ` Arnd Bergmann
2006-10-28 23:12 ` Arnd Bergmann
2006-10-30 15:46 ` Kyle McMartin
2006-10-30 15:59 ` Kyle McMartin
2006-10-31 7:02 ` Andrew Morton [this message]
2006-11-01 7:23 ` Stephen Rothwell
2006-11-01 14:24 ` Kyle McMartin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061030230210.041531ea.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=kyle@parisc-linux.org \
--cc=linux-arch@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox