From: Russell King <rmk@arm.linux.org.uk>
To: akpm@linux-foundation.org
Cc: mm-commits@vger.kernel.org, hch@lst.de, linux-arch@vger.kernel.org
Subject: Re: + move-die-notifier-handling-to-common-code.patch added to -mm tree
Date: Wed, 21 Mar 2007 22:17:48 +0000 [thread overview]
Message-ID: <20070321221748.GD28239@flint.arm.linux.org.uk> (raw)
In-Reply-To: <200703212211.l2LMB08x005006@shell0.pdx.osdl.net>
On Wed, Mar 21, 2007 at 03:11:00PM -0700, akpm@linux-foundation.org wrote:
> ------------------------------------------------------
> Subject: move die notifier handling to common code
> From: Christoph Hellwig <hch@lst.de>
>
> This patch moves the die notifier handling to common code. Previous
> various architectures had exactly the same code for it. Note that the new
> code is compiled unconditionally, this should be understood as an appel to
> the other architecture maintainer to implement support for it aswell (aka
> sprinkling a notify_die or two in the proper place)
>
> arm had a notifiy_die that did something totally different, I renamed it to
> arm_notify_die as part of the patch and made it static to the file it's
> declared and used at. avr32 used to pass slightly less information through
> this interface and I brought it into line with the other architectures.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Cc: <linux-arch@vger.kernel.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
NAK. This will, as seems to be the current favourite past time, break
ARM. A simple grep command will show why; I leave it as an exercise for
those to run this command to discover the details.
$ grep notify_die arch/arm -r
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
next prev parent reply other threads:[~2007-03-21 22:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-21 22:11 + move-die-notifier-handling-to-common-code.patch added to -mm tree akpm
2007-03-21 22:17 ` Russell King [this message]
2007-03-21 22:59 ` Andrew Morton
2007-03-22 10:01 ` Russell King
2007-03-23 17:51 ` Christoph Hellwig
2007-03-23 17:52 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070321221748.GD28239@flint.arm.linux.org.uk \
--to=rmk@arm.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=hch@lst.de \
--cc=linux-arch@vger.kernel.org \
--cc=mm-commits@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox