From: Matthew Wilcox <matthew@wil.cx>
To: David Miller <davem@davemloft.net>
Cc: rmk@arm.linux.org.uk, sam@ravnborg.org, linux-arch@vger.kernel.org
Subject: Re: missing syscalls
Date: Sun, 1 Apr 2007 14:09:47 -0600 [thread overview]
Message-ID: <20070401200947.GB826@parisc-linux.org> (raw)
In-Reply-To: <20070401.122345.123969742.davem@davemloft.net>
On Sun, Apr 01, 2007 at 12:23:45PM -0700, David Miller wrote:
> You should hook both of these syscalls up even if the config option
> that enables them usually is not, or cannot currently be, enabled.
>
> The cond_syscall()'s will make sure they always link properly and
> provide a -ENOSYS implementation.
>
> Hooking them up makes it easier to check future missed cases without
> us having to add a plethora of ifdefs to the missing syscall checks
> for each platform.
I haven't looked at the missing syscall check implementation, but it seems
like it's poorly designed if we have to add ifdefs for each arch. Why not
allow arches a mechanism to state which syscalls they intentionally
don't implement?
next prev parent reply other threads:[~2007-04-01 20:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-01 16:01 missing syscalls Sam Ravnborg
2007-04-01 19:15 ` Russell King
2007-04-01 19:23 ` David Miller
2007-04-01 20:09 ` Matthew Wilcox [this message]
2007-04-01 20:16 ` David Miller
2007-04-01 20:44 ` Matthew Wilcox
2007-04-01 20:19 ` Sam Ravnborg
2007-04-01 21:32 ` Russell King
2007-04-01 23:12 ` Arnd Bergmann
2007-04-01 19:23 ` Sam Ravnborg
2007-04-01 21:33 ` Russell King
2007-04-01 20:54 ` Andi Kleen
2007-04-01 21:10 ` Sam Ravnborg
2007-04-02 5:58 ` Andi Kleen
2007-04-02 12:31 ` Matthew Wilcox
2007-04-12 20:51 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070401200947.GB826@parisc-linux.org \
--to=matthew@wil.cx \
--cc=davem@davemloft.net \
--cc=linux-arch@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).