From: Matt Mackall <mpm@selenic.com>
To: Akinobu Mita <akinobu.mita@gmail.com>,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org
Subject: Re: [PATCH] slob: handle SLAB_PANIC flag
Date: Mon, 9 Apr 2007 09:57:58 -0500 [thread overview]
Message-ID: <20070409145758.GO4892@waste.org> (raw)
In-Reply-To: <20070409130847.GA5048@APFDCB5C>
On Mon, Apr 09, 2007 at 10:08:47PM +0900, Akinobu Mita wrote:
> kmem_cache_create() for slob doesn't handle SLAB_PANIC.
>
> Cc: Matt Mackall <mpm@selenic.com>
> Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
>
> ---
> mm/slob.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> Index: 2.6-mm/mm/slob.c
> ===================================================================
> --- 2.6-mm.orig/mm/slob.c
> +++ 2.6-mm/mm/slob.c
> @@ -298,6 +298,9 @@ struct kmem_cache *kmem_cache_create(con
> c->align = (flags & SLAB_MUST_HWCACHE_ALIGN) ? SLOB_ALIGN : 0;
> if (c->align < align)
> c->align = align;
> + } else {
> + if (flags & SLAB_PANIC)
> + panic("Cannot create slab cache %s\n", name);
> }
I think this would be more canonical:
} else if (..)
panic();
But otherwise,
Signed-off-by: Matt Mackall <mpm@selenic.com>
--
Mathematics is the supreme nostalgia of our time.
next prev parent reply other threads:[~2007-04-09 15:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-09 13:08 [PATCH] slob: handle SLAB_PANIC flag Akinobu Mita
2007-04-09 14:57 ` Matt Mackall [this message]
2007-04-09 16:25 ` Akinobu Mita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070409145758.GO4892@waste.org \
--to=mpm@selenic.com \
--cc=akinobu.mita@gmail.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox