linux-arch.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Roland McGrath <roland@redhat.com>, akpm@osdl.org
Cc: Christoph Hellwig <hch@lst.de>,
	linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org
Subject: condingstyle, was Re: utrace comments
Date: Mon, 30 Apr 2007 10:11:21 +0100	[thread overview]
Message-ID: <20070430091121.GC31397@infradead.org> (raw)
In-Reply-To: <20070430040213.BF9901801A4@magilla.sf.frob.com>

I've separated this out under a new subject because some style issues
that so far aren't documented explicitly are in doubt here, and Roland
wants and Answer from Andrew.

We also should put clauses on this into CodingStyle.


On Sun, Apr 29, 2007 at 09:02:13PM -0700, Roland McGrath wrote:
> > 	The coding style here is wrong.  The else should be on the line
> > 	of the closing brace.  
> 
> I can ordinarily ignore syntax, but this is an abomination in the sight
> of the Lord and always will be.  Fortunately, it's far from being 100%
> consistently used in the kernel already.  People are welcome to change
> the code after I submit it, but I just can't make myself write it that
> way, sorry.

> > 	This doesn't follow kernel coding style at all, we always
> > 	put the && or || operators at the end of the closing line.
> 
> I could swear I've been "corrected" in the opposite direction on this one.
> It is not mentioned in Documentation/CodingStyle, and the existing kernel
> code is far from consistent on it.  I really don't care which way it is,
> but I'd like clear authoritative direction from Linus and Andrew before I
> bother with it.


  parent reply	other threads:[~2007-04-30  9:11 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-27 16:51 utrace comments Christoph Hellwig
2006-12-05  9:51 ` Roland McGrath
2006-12-06 21:58   ` Christoph Hellwig
2007-04-30  4:02 ` Roland McGrath
2007-04-30  9:08   ` Christoph Hellwig
2007-04-30  9:18     ` Russell King
2007-04-30  9:22       ` Christoph Hellwig
2007-04-30  9:33         ` Russell King
2007-04-30  9:45           ` Russell King
2007-04-30 10:32             ` Christoph Hellwig
2007-04-30 10:18           ` Christoph Hellwig
2007-06-22  2:40           ` Roland McGrath
2007-05-10  8:49     ` Roland McGrath
2007-04-30  9:11   ` Christoph Hellwig [this message]
2007-04-30 17:09     ` condingstyle, was " Andrew Morton
2007-04-30 18:19       ` Jan Engelhardt
2007-04-30 18:39       ` Daniel Hazelton
2007-04-30 18:42       ` Satyam Sharma
2007-04-30 22:18         ` Stefan Richter
2007-05-01  9:00         ` Geert Uytterhoeven
2007-05-01 13:11           ` Scott Preece
2007-05-01 14:16           ` David Woodhouse
2007-05-01 15:00             ` John Anthony Kazos Jr.
2007-05-01 16:07               ` David Howells
2007-05-02  2:18                 ` Eric W. Biederman
2007-05-02  9:32                   ` David Howells
2007-05-02 11:55                     ` Eric W. Biederman
2007-05-02 12:05                       ` David Howells
2007-05-01 20:12               ` Satyam Sharma
2007-05-01 15:05             ` Randy Dunlap
2007-05-01 15:06               ` David Woodhouse
2007-05-01 20:44                 ` Satyam Sharma
2007-05-01 15:07             ` Geert Uytterhoeven
2007-05-01 15:11               ` David Woodhouse
2007-05-01 16:15         ` Stuart MacDonald
2007-04-30 21:34       ` Luck, Tony

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070430091121.GC31397@infradead.org \
    --to=hch@infradead.org \
    --cc=akpm@osdl.org \
    --cc=hch@lst.de \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=roland@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).