linux-arch.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Randy Dunlap <randy.dunlap@oracle.com>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
	Satyam Sharma <satyam.sharma@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Christoph Hellwig <hch@infradead.org>,
	Roland McGrath <roland@redhat.com>,
	Christoph Hellwig <hch@lst.de>,
	linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org
Subject: Re: condingstyle, was Re: utrace comments
Date: Tue, 1 May 2007 08:05:44 -0700	[thread overview]
Message-ID: <20070501080544.459a6ec9.randy.dunlap@oracle.com> (raw)
In-Reply-To: <1178028973.2875.78.camel@pmac.infradead.org>

On Tue, 01 May 2007 15:16:13 +0100 David Woodhouse wrote:

> On Tue, 2007-05-01 at 11:00 +0200, Geert Uytterhoeven wrote:
> > 
> >         if (veryverylengthycondition1 &&
> >             smallcond2 &&
> >             (conditionnumber3a ||
> >              condition3b)) {
> >                 ...
> >         }
> 
> It's horrid. I'd much rather see
> 
>         if (veryverylengthycondition1 &&
>             smallcond2 &&
>             (conditionnumber3a || condition3b)) {
>                 ...
>         }
> 
> Even if that does take it over 80 columns, the 'failure' mode will be
> that it gets wrapped round to the beginning of the screen or truncated
> at 80 columns -- and for the _majority_ of the time, it doesn't matter.
> 
> Unless you're paying particular attention to the logic and debugging the
> statement, a 'high-level' view of what's going on is perfectly
> sufficient; you don't actually read every character anyway.

I prefer this format also, but I'm not sure that we can get it
into CodingStyle.  CodingStyle is about (either) concensus or
dictum, but I don't see us close to concensus...

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

  parent reply	other threads:[~2007-05-01 15:08 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-27 16:51 utrace comments Christoph Hellwig
2006-12-05  9:51 ` Roland McGrath
2006-12-06 21:58   ` Christoph Hellwig
2007-04-30  4:02 ` Roland McGrath
2007-04-30  9:08   ` Christoph Hellwig
2007-04-30  9:18     ` Russell King
2007-04-30  9:22       ` Christoph Hellwig
2007-04-30  9:33         ` Russell King
2007-04-30  9:45           ` Russell King
2007-04-30 10:32             ` Christoph Hellwig
2007-04-30 10:18           ` Christoph Hellwig
2007-06-22  2:40           ` Roland McGrath
2007-05-10  8:49     ` Roland McGrath
2007-04-30  9:11   ` condingstyle, was " Christoph Hellwig
2007-04-30 17:09     ` Andrew Morton
2007-04-30 18:19       ` Jan Engelhardt
2007-04-30 18:39       ` Daniel Hazelton
2007-04-30 18:42       ` Satyam Sharma
2007-04-30 22:18         ` Stefan Richter
2007-05-01  9:00         ` Geert Uytterhoeven
2007-05-01 13:11           ` Scott Preece
2007-05-01 14:16           ` David Woodhouse
2007-05-01 15:00             ` John Anthony Kazos Jr.
2007-05-01 16:07               ` David Howells
2007-05-02  2:18                 ` Eric W. Biederman
2007-05-02  9:32                   ` David Howells
2007-05-02 11:55                     ` Eric W. Biederman
2007-05-02 12:05                       ` David Howells
2007-05-01 20:12               ` Satyam Sharma
2007-05-01 15:05             ` Randy Dunlap [this message]
2007-05-01 15:06               ` David Woodhouse
2007-05-01 20:44                 ` Satyam Sharma
2007-05-01 15:07             ` Geert Uytterhoeven
2007-05-01 15:11               ` David Woodhouse
2007-05-01 16:15         ` Stuart MacDonald
2007-04-30 21:34       ` Luck, Tony

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070501080544.459a6ec9.randy.dunlap@oracle.com \
    --to=randy.dunlap@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=dwmw2@infradead.org \
    --cc=geert@linux-m68k.org \
    --cc=hch@infradead.org \
    --cc=hch@lst.de \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=roland@redhat.com \
    --cc=satyam.sharma@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).