linux-arch.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: clameter@sgi.com
Cc: linux-arch@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: New slab allocator SLUB
Date: Thu, 10 May 2007 15:38:43 -0700 (PDT)	[thread overview]
Message-ID: <20070510.153843.66277978.davem@davemloft.net> (raw)
In-Reply-To: <20070510.153531.82102171.davem@davemloft.net>

From: David Miller <davem@davemloft.net>
Date: Thu, 10 May 2007 15:35:31 -0700 (PDT)

> From: Christoph Lameter <clameter@sgi.com>
> Date: Thu, 10 May 2007 15:33:30 -0700 (PDT)
> 
> > On Thu, 10 May 2007, David Miller wrote:
> > 
> > > From: Christoph Lameter <clameter@sgi.com>
> > > Date: Thu, 10 May 2007 15:21:52 -0700 (PDT)
> > > 
> > > > On Thu, 10 May 2007, David Miller wrote:
> > > > 
> > > > > What SLAB allows you to do is define LARGE_ALLOCS but not necessarily
> > > > > set MAX_ORDER large enough for the largest kmalloc SLAB.  SLAB would
> > > > > ignore the kmalloc cache creation failures for these largest ones that
> > > > > are over MAX_ORDER.
> > > > 
> > > > Hmmm... How about limiting KMALLOC_SHIFT_HIGH to max order?
> > > 
> > > That should definitely do the trick too:
> > 
> > Could you verify that it indeed does the trick?
> 
> Sure... give me a few minutes.

Ugh, it won't build, you can't use min() because this is
evaluated at compile time to compute array sizes etc.

include/linux/slub_def.h:76: error: braced-group within expression allowed only inside a function

  reply	other threads:[~2007-05-10 22:38 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-08 19:10 New slab allocator SLUB Christoph Lameter
2007-05-09  1:04 ` Paul Mundt
2007-05-09 13:36 ` Andi Kleen
2007-05-09 15:52   ` Christoph Lameter
2007-05-10 22:13 ` David Miller
2007-05-10 22:21   ` Christoph Lameter
2007-05-10 22:30     ` David Miller
2007-05-10 22:33       ` Christoph Lameter
2007-05-10 22:35         ` David Miller
2007-05-10 22:38           ` David Miller [this message]
2007-05-10 22:44             ` Christoph Lameter
2007-05-10 23:01               ` David Miller
2007-05-10 23:07                 ` Christoph Lameter
2007-05-11  0:05                   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070510.153843.66277978.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=akpm@linux-foundation.org \
    --cc=clameter@sgi.com \
    --cc=linux-arch@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).