linux-arch.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ralf Baechle <ralf@linux-mips.org>
To: David Woodhouse <dwmw2@infradead.org>
Cc: torvalds@osdl.org, akpm@osdl.org, paulus@samba.org,
	linux-arch@vger.kernel.org, drepper@redhat.com,
	rmk@arm.linux.org.uk
Subject: Re: Introduce fixed sys_sync_file_range2() syscall, implement on PowerPC and ARM
Date: Wed, 27 Jun 2007 15:22:59 +0200	[thread overview]
Message-ID: <20070627132259.GA5020@linux-mips.org> (raw)
In-Reply-To: <1182761357.12109.14.camel@pmac.infradead.org>

On Mon, Jun 25, 2007 at 09:49:17AM +0100, David Woodhouse wrote:

> Not all the world is an i386. Many architectures need 64-bit arguments
> to be aligned in suitable pairs of registers, and the original
> sys_sync_file_range(int, loff_t, loff_t, int) was therefore wasting an
> argument register for padding after the first integer. Since we don't
> normally have more than 6 arguments for system calls, that left no room
> for the final argument on some architectures.

The worse side of this class of problem is that at times new syscalls are
being invoked through pseudo-portable assembler code which on architectures
where where 64-bit values are being passed in an aligned pair frequently
end passing some of the arguments the wrong way.  For pread/pwrite this
did result in actual data corruption.

  Ralf

      parent reply	other threads:[~2007-06-27 13:24 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-25  8:49 Introduce fixed sys_sync_file_range2() syscall, implement on PowerPC and ARM David Woodhouse
2007-06-25  9:11 ` Andrew Morton
2007-06-25  9:48   ` David Woodhouse
2007-06-25 10:24     ` Matthew Wilcox
2007-06-25 10:35   ` Matthew Wilcox
2007-06-25 11:09     ` Russell King
2007-06-25 11:37       ` David Woodhouse
2007-06-25 11:47         ` Matthew Wilcox
2007-06-25 12:01           ` David Woodhouse
2007-06-25 12:04           ` Segher Boessenkool
2007-06-25 12:34             ` David Woodhouse
2007-06-25 13:10               ` Segher Boessenkool
2007-06-25 13:33                 ` David Woodhouse
2007-06-27 13:34           ` Ralf Baechle
2007-06-27 12:23         ` Geert Uytterhoeven
2007-06-25 11:33     ` David Howells
2007-06-25 14:35       ` Kyle McMartin
2007-06-27 13:22 ` Ralf Baechle [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070627132259.GA5020@linux-mips.org \
    --to=ralf@linux-mips.org \
    --cc=akpm@osdl.org \
    --cc=drepper@redhat.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=paulus@samba.org \
    --cc=rmk@arm.linux.org.uk \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).