From: Sam Ravnborg <sam@ravnborg.org>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Roman Zippel <zippel@linux-m68k.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
lkml <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Arch <linux-arch@vger.kernel.org>,
Al Viro <viro@ftp.linux.org.uk>
Subject: Re: [PATCH] cross-architecture ELF clean up
Date: Fri, 29 Jun 2007 20:12:05 +0200 [thread overview]
Message-ID: <20070629181205.GA16724@uranus.ravnborg.org> (raw)
In-Reply-To: <46851CF3.2070608@goop.org>
On Fri, Jun 29, 2007 at 10:53:39AM -0400, Jeremy Fitzhardinge wrote:
> Roman Zippel wrote:
> >The problem I have is that you want to separate _all_ constants, which
> >doesn't really make sense to me, because many of them are useless without
> >the correspending structures.
> >
>
> It seems cleanest to just put all the constants in one place rather than
> scatter them around based on how they happen to be used.
Grouping related things together is always a good approach. But the right
factor should be used for the grouping. For the ELF file is would from a usage
perspective be natural to have constants close to the definition that
they are used to describe. Having constants grouped with other constants just
_because_ they are constants does not cut here.
Sam
next prev parent reply other threads:[~2007-06-29 18:11 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070620230854.246399397@goop.org>
2007-06-20 23:08 ` [PATCH] cross-architecture ELF clean up Jeremy Fitzhardinge
2007-06-21 8:20 ` ian
2007-06-21 15:06 ` Jeremy Fitzhardinge
2007-06-21 16:49 ` Chris Zankel
2007-06-21 18:31 ` Jeremy Fitzhardinge
2007-06-25 9:02 ` David Woodhouse
2007-06-25 12:43 ` Jeremy Fitzhardinge
2007-06-25 13:40 ` Roman Zippel
2007-06-25 13:56 ` Clemens Koller
2007-06-25 14:06 ` Roman Zippel
2007-06-25 13:37 ` Roman Zippel
2007-06-26 19:29 ` Jeremy Fitzhardinge
2007-06-27 23:25 ` Roman Zippel
2007-06-28 15:45 ` Jeremy Fitzhardinge
2007-06-28 21:48 ` Roman Zippel
2007-06-29 14:53 ` Jeremy Fitzhardinge
2007-06-29 18:12 ` Sam Ravnborg [this message]
2007-07-01 16:23 ` Jeremy Fitzhardinge
2007-06-25 15:18 ` Roman Zippel
2007-06-26 19:28 ` Jeremy Fitzhardinge
2007-06-29 4:13 ` Paul Mackerras
2007-06-29 5:31 ` Jeremy Fitzhardinge
2007-06-29 4:48 ` Paul Mackerras
2007-06-29 5:31 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070629181205.GA16724@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=jeremy@goop.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ftp.linux.org.uk \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).