From: David Miller <davem@davemloft.net>
To: npiggin@suse.de
Cc: akpm@linux-foundation.org, paulus@samba.org, tony.luck@intel.com,
benh@kernel.crashing.org, linux-arch@vger.kernel.org
Subject: Re: [patch] bitops: lock bitops
Date: Wed, 11 Jul 2007 20:38:11 -0700 (PDT) [thread overview]
Message-ID: <20070711.203811.92584706.davem@davemloft.net> (raw)
In-Reply-To: <20070712031419.GF32414@wotan.suse.de>
From: Nick Piggin <npiggin@suse.de>
Date: Thu, 12 Jul 2007 05:14:19 +0200
> Here is a set of patches that aims to mitigate some of the lock_page
> overhead on powerpc introduced in the fault path by another set.
> Fortunately it also improves various other things too :)
>
> After this set, a dd if=./big-sparse-file of=/dev/null on my G5
> goes from 563MB/s to 575MB/s, or about 80ns less time per page.
> However I won't post the full set until after getting some acks
> from the arch people now, because it is a fair bit of churn in core
> code (eg. renaming !TestSetPageLocked to trylock_page).
>
> Not sure who else can take advantage of these. Sparc64 probably.
What I would code up on sparc64 would be basically equivalent to your
generic versions.
Or, more simply, I could just call test_and_clear_bit() et al.
directly and ignore the return value. There wouldn't be any
difference.
next prev parent reply other threads:[~2007-07-12 3:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-12 3:14 [patch] bitops: lock bitops Nick Piggin
2007-07-12 3:38 ` David Miller [this message]
2007-07-12 3:49 ` Nick Piggin
2007-07-12 21:36 ` Ralf Baechle
2007-07-23 6:06 ` Benjamin Herrenschmidt
2007-07-23 6:16 ` Nick Piggin
2007-07-23 9:50 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070711.203811.92584706.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=linux-arch@vger.kernel.org \
--cc=npiggin@suse.de \
--cc=paulus@samba.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).