linux-arch.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Andy Whitcroft <apw@shadowen.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-mm@kvack.org, linux-arch@vger.kernel.org,
	Christoph Hellwig <hch@infradead.org>,
	Nick Piggin <npiggin@suse.de>,
	Christoph Lameter <clameter@sgi.com>, Mel Gorman <mel@csn.ul.ie>
Subject: Re: [PATCH 3/4] vmemmap: pull out the vmemmap code into its own file
Date: Thu, 2 Aug 2007 14:26:21 +0100	[thread overview]
Message-ID: <20070802132621.GA9511@infradead.org> (raw)
In-Reply-To: <E1IGWw3-0002Xr-Dm@hellhawk.shadowen.org>

On Thu, Aug 02, 2007 at 10:25:35AM +0100, Andy Whitcroft wrote:
> + * Special Kconfig settings:
> + *
> + * CONFIG_ARCH_POPULATES_SPARSEMEM_VMEMMAP
> + *
> + * 	The architecture has its own functions to populate the memory
> + * 	map and provides a vmemmap_populate function.
> + *
> + * CONFIG_ARCH_POPULATES_SPARSEMEM_VMEMMAP_PMD
> + *
> + * 	The architecture provides functions to populate the pmd level
> + * 	of the vmemmap mappings.  Allowing mappings using large pages
> + * 	where available.
> + *
> + * 	If neither are set then PAGE_SIZE mappings are generated which
> + * 	require one PTE/TLB per PAGE_SIZE chunk of the virtual memory map.
> + */

This is the kinda of mess I mean.  Which architecturs set either of these
and why?  This code would be a lot more acceptable if we hadn't three
different variants of the arch interface.


  reply	other threads:[~2007-08-02 13:26 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-02  9:24 [PATCH 0/4] vmemmap updates to V6 Andy Whitcroft
2007-08-02  9:24 ` [PATCH 1/4] vmemmap: remove excess debugging Andy Whitcroft
2007-08-02 19:18   ` Christoph Lameter
2007-08-02  9:25 ` [PATCH 2/4] vmemmap: simplify initialisation code and reduce duplication Andy Whitcroft
2007-08-02  9:25 ` [PATCH 3/4] vmemmap: pull out the vmemmap code into its own file Andy Whitcroft
2007-08-02 13:26   ` Christoph Hellwig [this message]
2007-08-02 19:28     ` Christoph Lameter
2007-08-03 14:57       ` Andy Whitcroft
2007-08-03 16:58         ` Christoph Lameter
2007-08-02  9:25 ` [PATCH 4/4] vmemmap ppc64: convert VMM_* macros to a real function Andy Whitcroft
2007-08-02 16:31   ` Dave Hansen
2007-08-02 17:39     ` Andy Whitcroft
2007-08-02 18:00       ` Dave Hansen
2007-08-02 19:30     ` Christoph Lameter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070802132621.GA9511@infradead.org \
    --to=hch@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=apw@shadowen.org \
    --cc=clameter@sgi.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mel@csn.ul.ie \
    --cc=npiggin@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).