From: Andi Kleen <ak@suse.de>
To: akpm@linux-foundation.org
Cc: hch@lst.de, ananth@in.ibm.com, anil.s.keshavamurthy@intel.com,
linux-arch@vger.kernel.org, prasanna@in.ibm.com
Subject: Re: [patch 47/59] x86: optimize page faults like all other achitectures and kill notifier cruft
Date: Sat, 11 Aug 2007 01:17:33 +0200 [thread overview]
Message-ID: <200708110117.34171.ak@suse.de> (raw)
In-Reply-To: <200708102200.l7AM0CnU011952@imap1.linux-foundation.org>
On Saturday 11 August 2007 00:00:12 akpm@linux-foundation.org wrote:
> From: Christoph Hellwig <hch@lst.de>
>
> x86(-64) are the last architectures still using the page fault notifier
> cruft for the kprobes page fault hook. This patch converts them to the
> proper direct calls, and removes the now unused pagefault notifier bits
> aswell as the cruft in kprobes.c that was related to this mess.
>
> I know Andi didn't really like this, but all other architecture maintainers
> agreed the direct calls are much better and besides the obvious cruft
> removal a common way of dealing with kprobes across architectures is
> important aswell.
This means the debuggers just have to readd it. Not merged.
If you worry about cycles notifiers could be probably optimized a bit
for the nothing registered case.
-Andi
next prev parent reply other threads:[~2007-08-10 23:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-10 22:00 [patch 47/59] x86: optimize page faults like all other achitectures and kill notifier cruft akpm
2007-08-10 23:17 ` Andi Kleen [this message]
2007-08-10 23:52 ` Christoph Hellwig
2007-08-10 23:59 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200708110117.34171.ak@suse.de \
--to=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=ananth@in.ibm.com \
--cc=anil.s.keshavamurthy@intel.com \
--cc=hch@lst.de \
--cc=linux-arch@vger.kernel.org \
--cc=prasanna@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).