From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Chris Snook <csnook@redhat.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>, linux-arch@vger.kernel.org
Subject: Re: [RFP] atomic[64]_[read|set] asm implementations
Date: Wed, 15 Aug 2007 19:43:59 +0100 [thread overview]
Message-ID: <20070815184359.GA7300@flint.arm.linux.org.uk> (raw)
In-Reply-To: <46C33E19.3050805@redhat.com>
On Wed, Aug 15, 2007 at 01:55:37PM -0400, Chris Snook wrote:
> For architectures whose maintainers aren't worried and whose
> developers/users aren't bothered enough to submit an inline assembly
> patch, I'll just keep the inlines with the *(volatile foo *)& casts,
> unless of course ISO clarifies the C standard to different effect while
> we're arguing over semantics and micro-optimizations.
I have no problem with your latest patch for ARM. Moving ARM to
assembly will actually remove some information which the compiler
has when it knows about the access to be performed.
If atomic_read() were converted to inline assembly, we'd prevent the
compiler from knowing that a load has been performed and it should
therefore avoid using the result of the load where possible for the
following few instructions (due to result delays.)
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
prev parent reply other threads:[~2007-08-15 18:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-15 17:55 [RFP] atomic[64]_[read|set] asm implementations Chris Snook
2007-08-15 18:43 ` Russell King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070815184359.GA7300@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=csnook@redhat.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).