From: Paul Mundt <lethal@linux-sh.org>
To: Bryan Wu <bryan.wu@analog.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
uclinux-dist-devel@blackfin.uclinux.org,
linux-arch@vger.kernel.org
Subject: Re: [PATCH] Blackfin arch: add some missing syscall
Date: Thu, 13 Sep 2007 17:07:01 +0900 [thread overview]
Message-ID: <20070913080701.GB27871@linux-sh.org> (raw)
In-Reply-To: <1189670203.30686.15.camel@roc-desktop>
On Thu, Sep 13, 2007 at 03:56:43PM +0800, Bryan Wu wrote:
> @@ -352,9 +353,54 @@
> #define __NR_shmdt 340
> #define __NR_shmget 341
>
> -#define __NR_syscall 342
> +#define __NR_splice 342
> +#define __NR_sync_file_range 343
> +#define __NR_tee 344
> +#define __NR_vmsplice 345
> +
> +#define __NR_epoll_pwait 346
> +#define __NR_utimensat 347
> +#define __NR_signalfd 348
> +#define __NR_timerfd 349
> +#define __NR_eventfd 350
> +#define __NR_pread64 351
> +#define __NR_pwrite64 352
> +#define __NR_fadvise64 353
> +
> +#define __NR_syscall 354
> #define NR_syscalls __NR_syscall
>
Err, why did you change __NR_syscall? This is going to break the ABI for
anything using it, which is generally bad form.
You also missed sys_fallocate(), another reason to be using git, rather
than some silly subversion tree ;-)
next prev parent reply other threads:[~2007-09-13 8:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-13 7:56 [PATCH] Blackfin arch: add some missing syscall Bryan Wu
2007-09-13 8:07 ` Paul Mundt [this message]
2007-09-13 8:09 ` Paul Mundt
2007-09-13 8:18 ` Matthew Wilcox
2007-09-13 8:37 ` Mike Frysinger
2007-09-13 8:57 ` Bryan Wu
2007-09-13 11:03 ` [Uclinux-dist-devel] " Bernd Schmidt
2007-09-14 5:45 ` Bryan Wu
2007-09-14 6:44 ` Mike Frysinger
2007-09-14 7:32 ` Bryan Wu
2007-09-15 1:28 ` Mike Frysinger
2007-09-13 8:47 ` Paul Mundt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070913080701.GB27871@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=akpm@linux-foundation.org \
--cc=bryan.wu@analog.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).