From: Bernhard Walle <bwalle@suse.de>
To: Oleg Verych <olecom@flower.upol.cz>,
Andrew Morton <akpm@linux-foundation.org>
Cc: kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org
Subject: Re: [patch 1/7] Extended crashkernel command line
Date: Sun, 23 Sep 2007 22:19:43 +0200 [thread overview]
Message-ID: <20070923201943.GA5272@suse.de> (raw)
In-Reply-To: <E1IZEAi-00051i-23@flower>
* Oleg Verych <olecom@flower.upol.cz> [2007-09-23 01:14]:
> * Thu, 20 Sep 2007 19:18:46 +0200
>
> []
> > extern u32 vmcoreinfo_note[VMCOREINFO_NOTE_SIZE/4];
> > extern unsigned int vmcoreinfo_size;
> > extern unsigned int vmcoreinfo_max_size;
> > +int __init parse_crashkernel(char *cmdline, unsigned long long system_ram,
> > + unsigned long long *crash_size, unsigned long long *crash_base);
>
> (BTW, why `system_ram' is `unsigned long' in parse_crashkernel_mem() but
> `unsigned long long' in parse_crashkernel()?)
Because that's a bug, thanks for spotting that out. I will sent an
updated version of this patch until the issue below has been
clarified:
> What is the point of not using `ulong' and `u64'?
>
> What about another names?
>
> +int __init get_crashkernel_params(u64 *memsize, u64 *addrbase, char *cmdline, u64 ram);
Andrew, what's your opinion on this? Whould I resend the patch with
shorter type names?
Thanks,
Bernhard
next prev parent reply other threads:[~2007-09-23 20:19 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-20 17:18 [patch 0/7] Add extended crashkernel command line syntax Bernhard Walle
2007-09-20 17:18 ` [patch 1/7] Extended crashkernel command line Bernhard Walle
2007-09-22 23:14 ` Oleg Verych
2007-09-23 20:19 ` Bernhard Walle [this message]
2007-09-23 21:15 ` Oleg Verych
2007-09-23 21:04 ` Bernhard Walle
2007-09-20 17:18 ` [patch 2/7] Use extended crashkernel command line on i386 Bernhard Walle
2007-09-20 17:18 ` [patch 3/7] Use extended crashkernel command line on x86_64 Bernhard Walle
2007-09-20 17:18 ` [patch 4/7] Use extended crashkernel command line on ia64 Bernhard Walle
2007-09-20 17:18 ` [patch 5/7] Use extended crashkernel command line on ppc64 Bernhard Walle
2007-09-20 17:18 ` [patch 6/7] Use extended crashkernel command line on sh Bernhard Walle
2007-09-20 17:18 ` [patch 7/7] Add documentation for extended crashkernel syntax Bernhard Walle
-- strict thread matches above, loose matches on Subject: below --
2007-09-25 18:22 [patch 0/7] Add extended crashkernel command line syntax Bernhard Walle
2007-09-25 18:22 ` [patch 1/7] Extended crashkernel command line Bernhard Walle
2007-09-25 20:53 ` Oleg Verych
2007-09-26 8:34 ` Bernhard Walle
2007-09-26 16:16 ` Bernhard Walle
2007-09-26 18:18 ` Oleg Verych
2007-09-26 18:18 ` Bernhard Walle
2007-09-26 21:05 ` Bernhard Walle
2007-09-13 16:14 [patch 0/7] Add extended crashkernel command line syntax Bernhard Walle
2007-09-13 16:14 ` [patch 1/7] Extended crashkernel command line Bernhard Walle
2007-09-19 22:32 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070923201943.GA5272@suse.de \
--to=bwalle@suse.de \
--cc=akpm@linux-foundation.org \
--cc=kexec@lists.infradead.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olecom@flower.upol.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).