Re: [PATCH 01/12] lockdep: syscall exit check

[Heiko Carstens <heiko.carstens@de.ibm.com>]

On Fri, Sep 28, 2007 at 02:14:11PM +0200, Peter Zijlstra wrote:
> On Fri, 2007-09-28 at 14:03 +0200, Heiko Carstens wrote:
> > > +void lockdep_sys_exit(void)
> > > +{
> > > +	struct task_struct *curr = current;
> > > +
> > > +	if (unlikely(curr->lockdep_depth)) {
> > > +		if (!debug_locks_off())
> > > +			return;
> > > +		printk("\n========================================\n");
> > > +		printk(  "[ BUG: lock held at syscall exit time! ]\n");
> > > +		printk(  "----------------------------------------\n");
> > > +		printk("%s/%d is leaving the kernel with locks still held!\n",
> > > +				curr->comm, curr->pid);
> > > +		lockdep_print_held_locks(curr);
> > > +	}
> > > +}
> > 
> > By the way, the s390 patch I just posted also checks if we hold any locks
> > when returning from interrupt context to user space. Maybe the above text
> > could be changed to "lock held when returning to user space" ?
> 
> Good idea, I'll look at doing the same for i386/x86_64. Traps (page
> faults) would also make sense I guess.

Yes, traps and syscalls have the same exit path on s390. So we do that
alreasy as well.