From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:32919 "EHLO sunset.davemloft.net" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1753312AbXKAHBU (ORCPT ); Thu, 1 Nov 2007 03:01:20 -0400 Date: Thu, 01 Nov 2007 00:01:18 -0700 (PDT) Message-Id: <20071101.000118.208338243.davem@davemloft.net> Subject: Re: [patch 0/7] [RFC] SLUB: Improve allocpercpu to reduce per cpu access overhead From: David Miller In-Reply-To: References: <20071031.181335.207429553.davem@davemloft.net> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org To: clameter@sgi.com Cc: akpm@linux-foundation.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, mathieu.desnoyers@polymtl.ca, penberg@cs.helsinki.fi List-ID: From: Christoph Lameter Date: Wed, 31 Oct 2007 21:16:59 -0700 (PDT) > Index: linux-2.6/mm/allocpercpu.c > =================================================================== > --- linux-2.6.orig/mm/allocpercpu.c 2007-10-31 20:53:16.565486654 -0700 > +++ linux-2.6/mm/allocpercpu.c 2007-10-31 21:00:27.553486484 -0700 ... > @@ -37,7 +42,7 @@ enum unit_type { FREE, END, USED }; > > static u8 cpu_alloc_map[UNITS_PER_CPU] = { 1, }; > static DEFINE_SPINLOCK(cpu_alloc_map_lock); > -static DEFINE_PER_CPU(int, cpu_area)[UNITS_PER_CPU]; > +static DEFINE_PER_CPU(unsigned long long, cpu_area)[UNITS_PER_CPU]; > > #define CPU_DATA_OFFSET ((unsigned long)&per_cpu__cpu_area) > This hunk helped the sparc64 looping OOPS I was getting, but cpus hang in some other fashion soon afterwards. I'll try to debug this some more later, I've dumped enough time into this already :-)