From: Adrian Bunk <bunk@kernel.org>
To: linux-kernel@vger.kernel.org
Cc: linux-arch@vger.kernel.org
Subject: RFC: remove __read_mostly
Date: Thu, 13 Dec 2007 23:20:44 +0100 [thread overview]
Message-ID: <20071213222044.GH21616@stusta.de> (raw)
I tried the following patch with a full x86 .config [1]:
--- a/include/asm-x86/cache.h
+++ b/include/asm-x86/cache.h
-#define __read_mostly __attribute__((__section__(".data.read_mostly")))
+/* #define __read_mostly __attribute__((__section__(".data.read_mostly"))) */
The result [2,3] was:
-rwxrwxr-x 1 bunk bunk 46607243 2007-12-13 19:50 vmlinux.old
-rwxrwxr-x 1 bunk bunk 46598691 2007-12-13 21:55 vmlinux
It's not a surprise that the kernel can become bigger when __read_mostly
gets used, especially in cases where __read_mostly prevents gcc
optimizations.
My question is:
Is there anywhere in the kernel a case where __read_mostly brings a
measurable improvement or can it be removed?
cu
Adrian
[1] mostly allyesconfig with CONFIG_MODULES=n
[2] vmlinux.old is the unpatched kernel
[3] gcc 4.2 was used
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next reply other threads:[~2007-12-13 22:20 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-13 22:20 Adrian Bunk [this message]
2007-12-13 22:29 ` RFC: remove __read_mostly Andi Kleen
2007-12-13 22:41 ` Adrian Bunk
2007-12-14 16:16 ` Arnd Bergmann
2007-12-14 16:31 ` Eric Dumazet
2007-12-13 22:32 ` David Miller
2007-12-13 22:44 ` Harvey Harrison
2007-12-13 23:06 ` Andi Kleen
2007-12-13 22:48 ` Eric Dumazet
2007-12-13 23:00 ` Adrian Bunk
2007-12-13 23:54 ` Kyle McMartin
2007-12-14 0:33 ` Andi Kleen
2007-12-17 10:33 ` Andrew Morton
2007-12-17 10:53 ` Eric Dumazet
2007-12-17 11:07 ` Andrew Morton
2007-12-17 12:19 ` Andi Kleen
2007-12-17 12:15 ` Andi Kleen
2007-12-17 12:40 ` Adrian Bunk
2007-12-14 15:24 ` Matt Mackall
2007-12-14 15:38 ` Eric Dumazet
2007-12-14 15:42 ` Matt Mackall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071213222044.GH21616@stusta.de \
--to=bunk@kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).