From: Roman Zippel <zippel@linux-m68k.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Arch Mailing List <linux-arch@vger.kernel.org>,
Ralf Baechle <ralf@linux-mips.org>,
Sam Ravnborg <sam@ravnborg.org>, Paul Mundt <lethal@linux-sh.org>,
Richard Henderson <rth@twiddle.net>,
Michael Starvik <starvik@axis.com>,
David Howells <dhowells@redhat.com>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Hirokazu Takata <takata@linux-m32r.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
"William L. Irwin" <sparclinux@vger.kernel.org>,
Chris Zankel <chris@zankel.net>,
Jan Engelhardt <jengelh@computergmbh.de>
Subject: Re: [PATCH] Avoid overflows in kernel/time.c (version 5)
Date: Mon, 24 Dec 2007 01:14:12 +0100 [thread overview]
Message-ID: <200712240114.13431.zippel@linux-m68k.org> (raw)
In-Reply-To: <200712180541.lBI5fnqB028037@tazenda.hos.anvin.org>
Hi,
On Monday 17 December 2007, H. Peter Anvin wrote:
> kernel/timeconst.pl | 340
I agree with Jan that it would be better to put this into scripts.
In the long term we could also detect some of the simple special cases, so we
can finally inline some of these functions again, this would mean the
generated file would go into include/linux/ and the script should be in
scripts/.
> + my ($b,$n,$d) = @_;
I noticed this already in the old script, using something else than single
letter variables would increase readability considerably.
bye, Roman
prev parent reply other threads:[~2007-12-24 2:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-17 23:45 [PATCH] Avoid overflows in kernel/time.c (version 4) H. Peter Anvin
2007-12-18 5:37 ` Sam Ravnborg
2007-12-17 21:53 ` [PATCH] Avoid overflows in kernel/time.c (version 5) H. Peter Anvin
2007-12-23 2:58 ` Andrew Morton
2007-12-23 5:52 ` [PATCH] Avoid overflows in kernel/time.c (version 6) H. Peter Anvin
2007-12-24 0:14 ` Roman Zippel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200712240114.13431.zippel@linux-m68k.org \
--to=zippel@linux-m68k.org \
--cc=akpm@linux-foundation.org \
--cc=chris@zankel.net \
--cc=dhowells@redhat.com \
--cc=geert@linux-m68k.org \
--cc=hpa@zytor.com \
--cc=jengelh@computergmbh.de \
--cc=lethal@linux-sh.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ralf@linux-mips.org \
--cc=rth@twiddle.net \
--cc=sam@ravnborg.org \
--cc=sparclinux@vger.kernel.org \
--cc=starvik@axis.com \
--cc=takata@linux-m32r.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).