linux-arch.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin LaHaise <bcrl@kvack.org>
To: dipankar@in.ibm.com, Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org
Subject: [PATCH/RFC] synchronize_rcu(): high latency on idle system
Date: Fri, 11 Jan 2008 20:26:26 -0500	[thread overview]
Message-ID: <20080112012626.GI28570@kvack.org> (raw)

Hello folks,

I'd like to put the patch below out for comments to see if folks think the 
approach is a valid fix to reduce the latency of synchronize_rcu().  The 
motivation is that an otherwise idle system takes about 3 ticks per network 
interface in unregister_netdev() due to multiple calls to synchronize_rcu(), 
which adds up to quite a few seconds for tearing down thousands of 
interfaces.  By flushing pending rcu callbacks in the idle loop, the system 
makes progress hundreds of times faster.  If this is indeed a sane thing to, 
it probably needs to be done for other architectures than x86.  And yes, the 
network stack shouldn't call synchronize_rcu() quite so much, but fixing that 
is a little more involved.

		-ben

diff --git a/arch/x86/kernel/process_32.c b/arch/x86/kernel/process_32.c
index 9663c2a..592f6e4 100644
--- a/arch/x86/kernel/process_32.c
+++ b/arch/x86/kernel/process_32.c
@@ -188,6 +188,9 @@ void cpu_idle(void)
 			rmb();
 			idle = pm_idle;
 
+			if (rcu_pending(cpu))
+				rcu_check_callbacks(cpu, 0);
+
 			if (!idle)
 				idle = default_idle;
 

             reply	other threads:[~2008-01-12  1:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-12  1:26 Benjamin LaHaise [this message]
2008-01-12  2:37 ` [PATCH/RFC] synchronize_rcu(): high latency on idle system Andi Kleen
2008-01-12 17:51   ` Benjamin LaHaise
2008-01-12 18:35     ` Andi Kleen
2008-01-12  9:23 ` Peter Zijlstra
2008-01-12 16:55   ` Paul E. McKenney
2008-01-12 17:33   ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080112012626.GI28570@kvack.org \
    --to=bcrl@kvack.org \
    --cc=akpm@linux-foundation.org \
    --cc=dipankar@in.ibm.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).