From: Rusty Russell <rusty@rustcorp.com.au>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
linux-arch@vger.kernel.org,
Randy Dunlap <randy.dunlap@oracle.com>,
Adrian Bunk <bunk@kernel.org>
Subject: Re: [PATCH] kbuild: introduce blacklisting in modpost
Date: Mon, 21 Jan 2008 12:00:15 +1100 [thread overview]
Message-ID: <200801211200.16104.rusty@rustcorp.com.au> (raw)
In-Reply-To: <1200859743-24037-4-git-send-email-sam@ravnborg.org>
On Monday 21 January 2008 07:08:59 Sam Ravnborg wrote:
> Change the logic in modpost so we identify all the
> bad combinations of sections that refer to other
> sections.
...
> +/* The pattern is an array of simple patterns.
> + * "foo" will match an exact string equal to "foo"
> + * "foo*" will match a string that begins with "foo"
> + * "foo$" will match a string equal to "foo" or "foo.1"
> + * where the '1' can be any number including several digits.
> + * The $ syntax is for sections where ld append a dot number
> + * to make section name unique.
Dumb question: would it be easier to canonicalize all the section names by
removing trailing .[num]*, then using fnmatch() and standard wildcards?
The rest of the patches look really nice: thanks for doing this cleanup!
Rusty.
next prev parent reply other threads:[~2008-01-21 3:03 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-20 20:05 kbuild: improved Section mismatch detection Sam Ravnborg
2008-01-20 20:08 ` [PATCH] kbuild: fix so modpost can now check any .o file Sam Ravnborg
2008-01-20 20:08 ` [PATCH] kbuild: try harder to find symbol names in modpost Sam Ravnborg
2008-01-20 20:08 ` [PATCH] kbuild: code refactoring " Sam Ravnborg
2008-01-20 20:08 ` [PATCH] kbuild: introduce blacklisting " Sam Ravnborg
2008-01-20 20:09 ` [PATCH] kbuild: check section names consistently " Sam Ravnborg
2008-01-20 20:09 ` [PATCH] all archs: consolidate init and exit sections in vmlinux.lds.h Sam Ravnborg
2008-01-20 20:09 ` [PATCH] compiler.h: introduce __section() Sam Ravnborg
2008-01-20 20:09 ` [PATCH] Use separate sections for __dev/__cpu/__mem code/data Sam Ravnborg
2008-01-21 7:33 ` Paul Mundt
2008-01-21 9:57 ` Sam Ravnborg
2008-01-21 10:29 ` Andreas Schwab
2008-01-21 10:45 ` Sam Ravnborg
2008-01-21 10:47 ` Sam Ravnborg
2008-01-21 10:52 ` Paul Mundt
2008-01-21 12:06 ` Sam Ravnborg
2008-01-22 0:56 ` Paul Mundt
2008-01-22 3:25 ` Sam Ravnborg
2008-01-22 21:17 ` Greg KH
2008-01-22 21:25 ` Russell King
2008-01-21 1:00 ` Rusty Russell [this message]
2008-01-21 0:56 ` [PATCH] kbuild: fix so modpost can now check any .o file Rusty Russell
2008-01-21 6:11 ` Sam Ravnborg
2008-01-20 21:33 ` kbuild: improved Section mismatch detection Sam Ravnborg
2008-01-20 22:27 ` Adrian Bunk
2008-01-21 2:51 ` Sam Ravnborg
2008-01-21 20:31 ` Sam Ravnborg
2008-01-21 20:56 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200801211200.16104.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=bunk@kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).