linux-arch.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Matthew Wilcox <matthew@wil.cx>
To: linux-arch@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: down_killable implementations for every architecture
Date: Mon, 28 Jan 2008 16:19:18 -0700	[thread overview]
Message-ID: <20080128231918.GB31101@parisc-linux.org> (raw)


As part of the TASK_KILLABLE changes, we're going to need
down_killable().  Unfortunately, semaphores are implemented for every
architecture, which we should probably fix at some point.

On the plane ride down here, I did the necessary changes for each
architecture:

http://parisc-linux.org/~willy/down-killable/

I may have made mistakes.  Things to check:

 - The *_killable* functions should be exported for use by modules.
 - The down_killable implementation needs to check fatal_signal_pending,
   not signal_pending.
 - The task state needs to be set to TASK_KILLABLE, not
   TASK_INTERRUPTIBLE

It should only take a couple of minutes to verify your architecture.

-- 
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."

             reply	other threads:[~2008-01-28 23:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-28 23:19 Matthew Wilcox [this message]
2008-01-29  4:23 ` down_killable implementations for every architecture Andi Kleen
2008-02-06  3:04   ` Matthew Wilcox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080128231918.GB31101@parisc-linux.org \
    --to=matthew@wil.cx \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).