public inbox for linux-arch@vger.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Jeff Garzik <jeff@garzik.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	linux arch <linux-arch@vger.kernel.org>,
	James Bottomley <James.Bottomley@HansenPartnership.com>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: Are Section mismatches out of control?
Date: Fri, 1 Feb 2008 23:38:29 +0100	[thread overview]
Message-ID: <20080201223829.GB17828@uranus.ravnborg.org> (raw)
In-Reply-To: <47A37FE5.2060200@garzik.org>

On Fri, Feb 01, 2008 at 03:24:05PM -0500, Jeff Garzik wrote:
> Sam Ravnborg wrote:
> >One can ignore or one can fix...
> >I decided to spend some of my friday on fixing section mismatch
> >warnings as I've got a bit irritated over people spending time
> >complaining but failing to provide patches.
> 
> >	Sam - who expected more people to actually fix this stuff :-(
> 
> Well, with due respect, it's a bit presumptuous to add a bunch of 
> warnings to the kernel build (due to more strict checking), and then get 
> annoyed when people aren't jumping up and fixing this stuff immediately.

I did some testing and the new code does not emit warnings which were
not emitted before. But previously you had to use less typical
configurations to see them like HOTPLUG_CPU=y, HOTPLUG=n, gcc 3.3

> 
> There were no build complaints in 2.6.24 for my stuff (libata and 
> drivers/net) during my test builds, nor were there any for my 2.6.25-git 
> merge window pushes, nor were there any complaints when I last checked 
> Andrew's -mm tree.
> 
> So from our perspective, you dumped a lot of work in our laps from out 
> of the blue, getting irritated at us along the way.
> 
> Maybe we can resolve this in a more kinder, gentler, coordinated 
> fashion?  :)
It is the misinformation being spread that irritates me.
Thousand of hours, no real bugs found etc.

Anyway - that is all forgot tomorrow when we get the warning level down
to zero.
> 
> What could be done to prevent this sort of situation in the future? 
> Maybe add these checks to -mm, and then not push your strict checking 
> upstream until the build noise is reduced?

The good thing about getting it upstream is the additional attention.
If we do not get it down to acceptable levels I have no problems
turning off the section mismatch in minline but keep it enabled
in -mm.

	Sam

  reply	other threads:[~2008-02-01 22:38 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-01 10:47 Are Section mismatches out of control? Sam Ravnborg
2008-02-01 11:03 ` Andrew Morton
2008-02-01 11:21   ` Harvey Harrison
2008-02-01 13:30     ` Geert Uytterhoeven
2008-02-01 13:40       ` Sam Ravnborg
2008-02-01 21:22         ` Geert Uytterhoeven
2008-02-01 22:32           ` Sam Ravnborg
2008-02-02 16:42             ` Geert Uytterhoeven
2008-02-02 17:40               ` Sam Ravnborg
2008-02-01 17:02     ` Roland Dreier
2008-02-01 21:47     ` Jan Engelhardt
2008-02-01 22:10       ` James Bottomley
2008-02-01 22:40       ` Sam Ravnborg
2008-02-02  0:01         ` Jan Engelhardt
2008-02-01 14:48   ` Johannes Weiner
2008-02-01 15:00   ` James Bottomley
2008-02-01 16:43   ` Jeff Garzik
2008-02-01 20:17     ` Sam Ravnborg
2008-02-01 20:24       ` Jeff Garzik
2008-02-01 22:38         ` Sam Ravnborg [this message]
2008-02-01 11:10 ` Andi Kleen
2008-02-01 21:51   ` Jan Engelhardt
2008-02-02  4:12     ` Andi Kleen
2008-02-01 14:53 ` James Bottomley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080201223829.GB17828@uranus.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=akpm@linux-foundation.org \
    --cc=jeff@garzik.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox