Re: [PATCH] Use menuconfig for CONFIG_CPU_FREQ

[Russell King <rmk@arm.linux.org.uk>]

On Thu, Feb 14, 2008 at 03:00:12PM +0100, Roman Zippel wrote:
> Hi,
> 
> On Thu, 14 Feb 2008, Russell King wrote:
> 
> > Yes, I read that and didn't get the answer to the question above.  It's
> > unclear how:
> > 
> > config CPU_FREQ_INTEGRATOR
> >         tristate "CPUfreq driver for ARM Integrator CPUs"
> >         depends on ARCH_INTEGRATOR && CPU_FREQ
> > 
> > being under CPU_FREQ rather than ARCH_INTEGRATOR
> 
> The doc says it looks at "the previous entry" and ARCH_INTEGRATOR isn't 
> exactly the previous entry.

Neither is CPU_FREQ "the previous entry".  The documentation is unclear.

> For me it was kind of obvious that kconfig wouldn't arbitrarily reorder 
> the menu entries.

It's always obvious for the person who wrote the code.  It isn't for those
who haven't.

> Only the indentation of an entry is changed not the 
> whole order. Any contributions to clarify this are more than welcome.

Well, I still don't have the necessary understanding to work out how
CPU_FREQ is preferred over ARCH_INTEGRATOR, even with your statements
that "it is the case".  So I'm not in a position to improve the
documentation except by adding a sentence to suggest people ask you
about it.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of: