From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: linux-pci@atrey.karlin.mff.cuni.cz
Cc: linux-arch@vger.kernel.org, Chris Zankel <chris@zankel.net>,
Grant Grundler <grundler@parisc-linux.org>,
linux-parisc@vger.kernel.org, Matthew Wilcox <matthew@wil.cx>,
Kyle McMartin <kyle@parisc-linux.org>,
linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>,
linux-arm-kernel@lists.arm.linux.org.uk,
Russell King <rmk@arm.linux.org.uk>,
Bjorn Helgaas <bjorn.helgaas@hp.com>
Subject: Re: [patch 4/6] ARM: move bridge enable out of pcibios_enable_resources()
Date: Mon, 3 Mar 2008 09:59:35 -0800 [thread overview]
Message-ID: <200803030959.35625.jbarnes@virtuousgeek.org> (raw)
In-Reply-To: <20080228001053.013269726@ldl.fc.hp.com>
On Wednesday, February 27, 2008 4:04 pm Bjorn Helgaas wrote:
> Move bridge enable from pcibios_enable_resources() to
> platform_pci_enable_device() so the former matches other
> architectures and can be shared.
I really like the direction of these patches. Getting PCI resources assigned
& devices setup correctly for new arches has always been a bit more trouble
than it should be...
>
> Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
>
> Index: work6/arch/arm/kernel/bios32.c
> ===================================================================
> --- work6.orig/arch/arm/kernel/bios32.c 2008-02-27 11:25:29.000000000 -0700
> +++ work6/arch/arm/kernel/bios32.c 2008-02-27 11:55:59.000000000 -0700
> @@ -683,15 +683,32 @@
> cmd |= PCI_COMMAND_MEMORY;
> }
>
> + if (cmd != old_cmd) {
> + printk("PCI: enabling device %s (%04x -> %04x)\n",
> + pci_name(dev), old_cmd, cmd);
Probably worth giving this printk a prefix at some point (doesn't matter for
this patchset though since you're just moving it around).
Rest of it looks good.
Jesse
WARNING: multiple messages have this Message-ID (diff)
From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: linux-pci@atrey.karlin.mff.cuni.cz
Cc: Bjorn Helgaas <bjorn.helgaas@hp.com>,
linux-arch@vger.kernel.org, Russell King <rmk@arm.linux.org.uk>,
linux-arm-kernel@lists.arm.linux.org.uk,
Kyle McMartin <kyle@parisc-linux.org>,
Matthew Wilcox <matthew@wil.cx>,
Grant Grundler <grundler@parisc-linux.org>,
linux-parisc@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
linuxppc-dev@ozlabs.org, Chris Zankel <chris@zankel.net>
Subject: Re: [patch 4/6] ARM: move bridge enable out of pcibios_enable_resources()
Date: Mon, 3 Mar 2008 09:59:35 -0800 [thread overview]
Message-ID: <200803030959.35625.jbarnes@virtuousgeek.org> (raw)
Message-ID: <20080303175935.zMS4x3dLExkwGme_4B1Yu-xBGnyUGnyxYmL8oLEwDQg@z> (raw)
In-Reply-To: <20080228001053.013269726@ldl.fc.hp.com>
On Wednesday, February 27, 2008 4:04 pm Bjorn Helgaas wrote:
> Move bridge enable from pcibios_enable_resources() to
> platform_pci_enable_device() so the former matches other
> architectures and can be shared.
I really like the direction of these patches. Getting PCI resources assigned
& devices setup correctly for new arches has always been a bit more trouble
than it should be...
>
> Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
>
> Index: work6/arch/arm/kernel/bios32.c
> ===================================================================
> --- work6.orig/arch/arm/kernel/bios32.c 2008-02-27 11:25:29.000000000 -0700
> +++ work6/arch/arm/kernel/bios32.c 2008-02-27 11:55:59.000000000 -0700
> @@ -683,15 +683,32 @@
> cmd |= PCI_COMMAND_MEMORY;
> }
>
> + if (cmd != old_cmd) {
> + printk("PCI: enabling device %s (%04x -> %04x)\n",
> + pci_name(dev), old_cmd, cmd);
Probably worth giving this printk a prefix at some point (doesn't matter for
this patchset though since you're just moving it around).
Rest of it looks good.
Jesse
next prev parent reply other threads:[~2008-03-03 17:59 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-28 0:04 [patch 0/6] RFC: PCI: consolidate pcibios_enable_resources() implementations, v2 Bjorn Helgaas
2008-02-28 0:04 ` [patch 1/6] PCI: split pcibios_enable_resources() out of pcibios_enable_device() Bjorn Helgaas
2008-02-28 0:04 ` [patch 2/6] ppc: make pcibios_enable_device() use pcibios_enable_resources() Bjorn Helgaas
2008-02-28 0:04 ` [patch 3/6] xtensa: " Bjorn Helgaas
2008-02-28 0:04 ` [patch 4/6] ARM: move bridge enable out of pcibios_enable_resources() Bjorn Helgaas
2008-03-03 17:59 ` Jesse Barnes [this message]
2008-03-03 17:59 ` Jesse Barnes
2008-03-03 20:35 ` Benjamin Herrenschmidt
2008-03-03 20:35 ` Benjamin Herrenschmidt
2008-03-03 20:43 ` Jesse Barnes
2008-03-03 20:43 ` Jesse Barnes
2008-03-06 15:06 ` Russell King - ARM Linux
2008-03-06 15:06 ` Russell King - ARM Linux
[not found] ` <20080306150640.GL3283-f404yB8NqCZvn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2008-03-06 15:42 ` Bjorn Helgaas
2008-03-06 15:42 ` Bjorn Helgaas
2008-02-28 0:04 ` [patch 5/6] PARISC: move PERR & SERR enables " Bjorn Helgaas
2008-02-28 17:31 ` Grant Grundler
2008-03-03 18:30 ` Jesse Barnes
2008-03-03 18:30 ` Jesse Barnes
2008-02-28 17:38 ` Kyle McMartin
2008-02-28 0:04 ` [patch 6/6] PCI: consolidate several pcibios_enable_resources() implementations Bjorn Helgaas
[not found] ` <20080228001053.404893334-e+Ta4ugHZmL3oGB3hsPCZA@public.gmane.org>
2008-03-03 18:45 ` Jesse Barnes
2008-03-03 18:45 ` Jesse Barnes
[not found] ` <200803031045.07054.jbarnes-Y1mF5jBUw70BENJcbMCuUQ@public.gmane.org>
2008-03-03 19:10 ` Bjorn Helgaas
2008-03-03 19:10 ` Bjorn Helgaas
[not found] ` <20080228000437.880811124-e+Ta4ugHZmL3oGB3hsPCZA@public.gmane.org>
2008-03-03 19:44 ` [patch 0/6] RFC: PCI: consolidate pcibios_enable_resources() implementations, v2 Russell King
2008-03-03 19:44 ` Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200803030959.35625.jbarnes@virtuousgeek.org \
--to=jbarnes@virtuousgeek.org \
--cc=bjorn.helgaas@hp.com \
--cc=chris@zankel.net \
--cc=grundler@parisc-linux.org \
--cc=kyle@parisc-linux.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=linuxppc-dev@ozlabs.org \
--cc=matthew@wil.cx \
--cc=paulus@samba.org \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox