From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [patch 4/6] ARM: move bridge enable out of pcibios_enable_resources() Date: Mon, 3 Mar 2008 09:59:35 -0800 Message-ID: <200803030959.35625.jbarnes@virtuousgeek.org> References: <20080228000437.880811124@ldl.fc.hp.com> <20080228001053.013269726@ldl.fc.hp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20080228001053.013269726@ldl.fc.hp.com> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@ozlabs.org Errors-To: linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@ozlabs.org To: linux-pci@atrey.karlin.mff.cuni.cz Cc: linux-arch@vger.kernel.org, Chris Zankel , Grant Grundler , linux-parisc@vger.kernel.org, Matthew Wilcox , Kyle McMartin , linuxppc-dev@ozlabs.org, Paul Mackerras , linux-arm-kernel@lists.arm.linux.org.uk, Russell King , Bjorn Helgaas List-Id: linux-arch.vger.kernel.org On Wednesday, February 27, 2008 4:04 pm Bjorn Helgaas wrote: > Move bridge enable from pcibios_enable_resources() to > platform_pci_enable_device() so the former matches other > architectures and can be shared. I really like the direction of these patches. Getting PCI resources assigned & devices setup correctly for new arches has always been a bit more trouble than it should be... > > Signed-off-by: Bjorn Helgaas > > Index: work6/arch/arm/kernel/bios32.c > =================================================================== > --- work6.orig/arch/arm/kernel/bios32.c 2008-02-27 11:25:29.000000000 -0700 > +++ work6/arch/arm/kernel/bios32.c 2008-02-27 11:55:59.000000000 -0700 > @@ -683,15 +683,32 @@ > cmd |= PCI_COMMAND_MEMORY; > } > > + if (cmd != old_cmd) { > + printk("PCI: enabling device %s (%04x -> %04x)\n", > + pci_name(dev), old_cmd, cmd); Probably worth giving this printk a prefix at some point (doesn't matter for this patchset though since you're just moving it around). Rest of it looks good. Jesse From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from outbound-mail-104.bluehost.com ([69.89.22.14]:37781 "HELO outbound-mail-104.bluehost.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751914AbYCCSHW (ORCPT ); Mon, 3 Mar 2008 13:07:22 -0500 From: Jesse Barnes Subject: Re: [patch 4/6] ARM: move bridge enable out of pcibios_enable_resources() Date: Mon, 3 Mar 2008 09:59:35 -0800 References: <20080228000437.880811124@ldl.fc.hp.com> <20080228001053.013269726@ldl.fc.hp.com> In-Reply-To: <20080228001053.013269726@ldl.fc.hp.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-ID: <200803030959.35625.jbarnes@virtuousgeek.org> Sender: linux-arch-owner@vger.kernel.org List-ID: To: linux-pci@atrey.karlin.mff.cuni.cz Cc: Bjorn Helgaas , linux-arch@vger.kernel.org, Russell King , linux-arm-kernel@lists.arm.linux.org.uk, Kyle McMartin , Matthew Wilcox , Grant Grundler , linux-parisc@vger.kernel.org, Paul Mackerras , Benjamin Herrenschmidt , linuxppc-dev@ozlabs.org, Chris Zankel Message-ID: <20080303175935.zMS4x3dLExkwGme_4B1Yu-xBGnyUGnyxYmL8oLEwDQg@z> On Wednesday, February 27, 2008 4:04 pm Bjorn Helgaas wrote: > Move bridge enable from pcibios_enable_resources() to > platform_pci_enable_device() so the former matches other > architectures and can be shared. I really like the direction of these patches. Getting PCI resources assigned & devices setup correctly for new arches has always been a bit more trouble than it should be... > > Signed-off-by: Bjorn Helgaas > > Index: work6/arch/arm/kernel/bios32.c > =================================================================== > --- work6.orig/arch/arm/kernel/bios32.c 2008-02-27 11:25:29.000000000 -0700 > +++ work6/arch/arm/kernel/bios32.c 2008-02-27 11:55:59.000000000 -0700 > @@ -683,15 +683,32 @@ > cmd |= PCI_COMMAND_MEMORY; > } > > + if (cmd != old_cmd) { > + printk("PCI: enabling device %s (%04x -> %04x)\n", > + pci_name(dev), old_cmd, cmd); Probably worth giving this printk a prefix at some point (doesn't matter for this patchset though since you're just moving it around). Rest of it looks good. Jesse