From: Jesse Barnes <jbarnes-Y1mF5jBUw70BENJcbMCuUQ@public.gmane.org>
To: linux-pci-jyMamyUUXNJG4ohzP4jBZS1Fcj925eT/@public.gmane.org
Cc: Bjorn Helgaas <bjorn.helgaas-VXdhtT5mjnY@public.gmane.org>,
linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Russell King <rmk-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
linux-arm-kernel-xIg/pKzrS19vn6HldHNs0ANdhmdF6hFW@public.gmane.org,
Kyle McMartin <kyle-6jwH94ZQLHl74goWV3ctuw@public.gmane.org>,
Matthew Wilcox <matthew-Ztpu424NOJ8@public.gmane.org>,
Grant Grundler <grundler-6jwH94ZQLHl74goWV3ctuw@public.gmane.org>,
linux-parisc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Paul Mackerras <paulus-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>,
Benjamin Herrenschmidt
<benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>,
linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org,
Chris Zankel <chris-YvXeqwSYzG2sTnJN9+BGXg@public.gmane.org>
Subject: Re: [patch 6/6] PCI: consolidate several pcibios_enable_resources() implementations
Date: Mon, 3 Mar 2008 10:45:06 -0800 [thread overview]
Message-ID: <200803031045.07054.jbarnes@virtuousgeek.org> (raw)
In-Reply-To: <20080228001053.404893334-e+Ta4ugHZmL3oGB3hsPCZA@public.gmane.org>
On Wednesday, February 27, 2008 4:04 pm Bjorn Helgaas wrote:
> There are many implementations of pcibios_enable_resources() that differ
> in minor ways that look more like bugs than architectural differences.
>
> This patch consolidates most of them to use the version annotated below.
> This is the original x86 version, except that it uses the resource
> collision check from powerpc at (5):
Looks really good to me, definitely a step in the right direction.
> The mips/pmc-sierra implementation of pcibios_enable_resources() is
> cluttered with a bunch of titan stuff, so I can't immediately consolidate
> it with the others. So I made the generic version "weak" so pmc-sierra
> can override it.
>
> Not-Yet-Signed-off-by: Bjorn Helgaas <bjorn.helgaas-VXdhtT5mjnY@public.gmane.org>
So you'd like to see the MIPS stuff cleaned up a bit more first before actual
sign-off? Or just more testing?
> 18 files changed, 43 insertions(+), 507 deletions(-)
Nice diffstat. :)
Jesse
--
To unsubscribe from this list: send the line "unsubscribe linux-arch" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: linux-pci@atrey.karlin.mff.cuni.cz
Cc: Bjorn Helgaas <bjorn.helgaas@hp.com>,
linux-arch@vger.kernel.org, Russell King <rmk@arm.linux.org.uk>,
linux-arm-kernel@lists.arm.linux.org.uk,
Kyle McMartin <kyle@parisc-linux.org>,
Matthew Wilcox <matthew@wil.cx>,
Grant Grundler <grundler@parisc-linux.org>,
linux-parisc@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
linuxppc-dev@ozlabs.org, Chris Zankel <chris@zankel.net>
Subject: Re: [patch 6/6] PCI: consolidate several pcibios_enable_resources() implementations
Date: Mon, 3 Mar 2008 10:45:06 -0800 [thread overview]
Message-ID: <200803031045.07054.jbarnes@virtuousgeek.org> (raw)
Message-ID: <20080303184506.WMUpPcT2OILrl6BZ4APYyxZJLNPn4eTjYXzuZXiYTc4@z> (raw)
In-Reply-To: <20080228001053.404893334@ldl.fc.hp.com>
On Wednesday, February 27, 2008 4:04 pm Bjorn Helgaas wrote:
> There are many implementations of pcibios_enable_resources() that differ
> in minor ways that look more like bugs than architectural differences.
>
> This patch consolidates most of them to use the version annotated below.
> This is the original x86 version, except that it uses the resource
> collision check from powerpc at (5):
Looks really good to me, definitely a step in the right direction.
> The mips/pmc-sierra implementation of pcibios_enable_resources() is
> cluttered with a bunch of titan stuff, so I can't immediately consolidate
> it with the others. So I made the generic version "weak" so pmc-sierra
> can override it.
>
> Not-Yet-Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
So you'd like to see the MIPS stuff cleaned up a bit more first before actual
sign-off? Or just more testing?
> 18 files changed, 43 insertions(+), 507 deletions(-)
Nice diffstat. :)
Jesse
next prev parent reply other threads:[~2008-03-03 18:45 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-28 0:04 [patch 0/6] RFC: PCI: consolidate pcibios_enable_resources() implementations, v2 Bjorn Helgaas
2008-02-28 0:04 ` [patch 1/6] PCI: split pcibios_enable_resources() out of pcibios_enable_device() Bjorn Helgaas
2008-02-28 0:04 ` [patch 2/6] ppc: make pcibios_enable_device() use pcibios_enable_resources() Bjorn Helgaas
2008-02-28 0:04 ` [patch 3/6] xtensa: " Bjorn Helgaas
2008-02-28 0:04 ` [patch 4/6] ARM: move bridge enable out of pcibios_enable_resources() Bjorn Helgaas
2008-03-03 17:59 ` Jesse Barnes
2008-03-03 17:59 ` Jesse Barnes
2008-03-03 20:35 ` Benjamin Herrenschmidt
2008-03-03 20:35 ` Benjamin Herrenschmidt
2008-03-03 20:43 ` Jesse Barnes
2008-03-03 20:43 ` Jesse Barnes
2008-03-06 15:06 ` Russell King - ARM Linux
2008-03-06 15:06 ` Russell King - ARM Linux
[not found] ` <20080306150640.GL3283-f404yB8NqCZvn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2008-03-06 15:42 ` Bjorn Helgaas
2008-03-06 15:42 ` Bjorn Helgaas
2008-02-28 0:04 ` [patch 5/6] PARISC: move PERR & SERR enables " Bjorn Helgaas
2008-02-28 17:31 ` Grant Grundler
2008-03-03 18:30 ` Jesse Barnes
2008-03-03 18:30 ` Jesse Barnes
2008-02-28 17:38 ` Kyle McMartin
2008-02-28 0:04 ` [patch 6/6] PCI: consolidate several pcibios_enable_resources() implementations Bjorn Helgaas
[not found] ` <20080228001053.404893334-e+Ta4ugHZmL3oGB3hsPCZA@public.gmane.org>
2008-03-03 18:45 ` Jesse Barnes [this message]
2008-03-03 18:45 ` Jesse Barnes
[not found] ` <200803031045.07054.jbarnes-Y1mF5jBUw70BENJcbMCuUQ@public.gmane.org>
2008-03-03 19:10 ` Bjorn Helgaas
2008-03-03 19:10 ` Bjorn Helgaas
[not found] ` <20080228000437.880811124-e+Ta4ugHZmL3oGB3hsPCZA@public.gmane.org>
2008-03-03 19:44 ` [patch 0/6] RFC: PCI: consolidate pcibios_enable_resources() implementations, v2 Russell King
2008-03-03 19:44 ` Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200803031045.07054.jbarnes@virtuousgeek.org \
--to=jbarnes-y1mf5jbuw70benjcbmcuuq@public.gmane.org \
--cc=benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org \
--cc=bjorn.helgaas-VXdhtT5mjnY@public.gmane.org \
--cc=chris-YvXeqwSYzG2sTnJN9+BGXg@public.gmane.org \
--cc=grundler-6jwH94ZQLHl74goWV3ctuw@public.gmane.org \
--cc=kyle-6jwH94ZQLHl74goWV3ctuw@public.gmane.org \
--cc=linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-arm-kernel-xIg/pKzrS19vn6HldHNs0ANdhmdF6hFW@public.gmane.org \
--cc=linux-parisc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-pci-jyMamyUUXNJG4ohzP4jBZS1Fcj925eT/@public.gmane.org \
--cc=linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org \
--cc=matthew-Ztpu424NOJ8@public.gmane.org \
--cc=paulus-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org \
--cc=rmk-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox