linux-arch.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: linux-pci@atrey.karlin.mff.cuni.cz, linux-arch@vger.kernel.org
Cc: Russell King <rmk@arm.linux.org.uk>,
	linux-arm-kernel@lists.arm.linux.org.uk,
	Kyle McMartin <kyle@parisc-linux.org>,
	Matthew Wilcox <matthew@wil.cx>,
	Grant Grundler <grundler@parisc-linux.org>,
	linux-parisc@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	linuxppc-dev@ozlabs.org, Chris Zankel <chris@zankel.net>
Subject: [patch 14/16] v850: use generic pci_enable_resources()
Date: Tue, 04 Mar 2008 11:57:00 -0700	[thread overview]
Message-ID: <20080304185822.542010547@ldl.fc.hp.com> (raw)
In-Reply-To: 20080304185646.864917286@ldl.fc.hp.com

[-- Attachment #1: v850-use-pci_enable_resources --]
[-- Type: text/plain, Size: 1523 bytes --]

Use the generic pci_enable_resources() instead of the arch-specific code.

Unlike this arch-specific code, the generic version:
    - checks PCI_NUM_RESOURCES (11), not 6, resources
    - skips resources that have neither IORESOURCE_IO nor IORESOURCE_MEM set
    - skips ROM resources unless IORESOURCE_ROM_ENABLE is set
    - checks for resource collisions with "!r->parent"

Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>

Index: work8/arch/v850/kernel/rte_mb_a_pci.c
===================================================================
--- work8.orig/arch/v850/kernel/rte_mb_a_pci.c	2008-03-04 10:12:04.000000000 -0700
+++ work8/arch/v850/kernel/rte_mb_a_pci.c	2008-03-04 10:12:26.000000000 -0700
@@ -219,30 +219,7 @@
 \f
 int __nomods_init pcibios_enable_device (struct pci_dev *dev, int mask)
 {
-	u16 cmd, old_cmd;
-	int idx;
-	struct resource *r;
-
-	pci_read_config_word(dev, PCI_COMMAND, &cmd);
-	old_cmd = cmd;
-	for (idx = 0; idx < 6; idx++) {
-		r = &dev->resource[idx];
-		if (!r->start && r->end) {
-			printk(KERN_ERR "PCI: Device %s not available because "
-			       "of resource collisions\n", pci_name(dev));
-			return -EINVAL;
-		}
-		if (r->flags & IORESOURCE_IO)
-			cmd |= PCI_COMMAND_IO;
-		if (r->flags & IORESOURCE_MEM)
-			cmd |= PCI_COMMAND_MEMORY;
-	}
-	if (cmd != old_cmd) {
-		printk("PCI: Enabling device %s (%04x -> %04x)\n",
-		       pci_name(dev), old_cmd, cmd);
-		pci_write_config_word(dev, PCI_COMMAND, cmd);
-	}
-	return 0;
+	return pci_enable_resources(dev, mask);
 }
 
 \f

-- 

  parent reply	other threads:[~2008-03-04 18:56 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-04 18:56 [patch 00/16] PCI: consolidate several pcibios_enable_resources() implementations, v3 Bjorn Helgaas
2008-03-04 18:56 ` [patch 01/16] PCI: add generic pci_enable_resources() Bjorn Helgaas
2008-03-05 14:53   ` David Howells
2008-03-05 14:53     ` David Howells
2008-03-05 20:14     ` Greg KH
2008-03-05 20:14       ` Greg KH
2008-03-04 18:56 ` [patch 02/16] alpha: use " Bjorn Helgaas
2008-03-04 18:56 ` [patch 03/16] arm: " Bjorn Helgaas
2008-03-04 18:56 ` [patch 04/16] cris: " Bjorn Helgaas
2008-03-04 18:56 ` [patch 05/16] frv: " Bjorn Helgaas
2008-03-05 14:52   ` David Howells
2008-03-05 14:52     ` David Howells
2008-03-05 20:14     ` Greg KH
2008-03-05 20:14       ` Greg KH
2008-03-04 18:56 ` [patch 06/16] ia64: " Bjorn Helgaas
2008-03-04 18:56 ` [patch 07/16] mips: " Bjorn Helgaas
2008-03-04 18:56 ` [patch 08/16] mn10300: " Bjorn Helgaas
2008-03-05 15:13   ` David Howells
2008-03-05 15:13     ` David Howells
     [not found]     ` <28205.1204729990-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2008-03-05 20:15       ` Greg KH
2008-03-05 20:15         ` Greg KH
2008-03-04 18:56 ` [patch 09/16] parisc: " Bjorn Helgaas
     [not found]   ` <20080304185821.554040328-e+Ta4ugHZmL3oGB3hsPCZA@public.gmane.org>
2008-03-05 16:17     ` Kyle McMartin
2008-03-05 16:17       ` Kyle McMartin
     [not found]       ` <20080305161709.GA3354-EK4dZfYtfFRW/gs8oUvUg/d9D2ou9A/h@public.gmane.org>
2008-03-05 20:09         ` Greg KH
2008-03-05 20:09           ` Greg KH
2008-03-04 18:56 ` [patch 10/16] powerpc: " Bjorn Helgaas
2008-03-04 18:56 ` [patch 11/16] ppc: " Bjorn Helgaas
2008-03-04 18:56 ` [patch 12/16] sh: " Bjorn Helgaas
2008-03-04 18:56 ` [patch 13/16] sparc64: " Bjorn Helgaas
2008-03-04 18:57 ` Bjorn Helgaas [this message]
2008-03-04 18:57 ` [patch 15/16] x86: " Bjorn Helgaas
2008-03-04 18:57 ` [patch 16/16] xtensa: " Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080304185822.542010547@ldl.fc.hp.com \
    --to=bjorn.helgaas@hp.com \
    --cc=benh@kernel.crashing.org \
    --cc=chris@zankel.net \
    --cc=grundler@parisc-linux.org \
    --cc=kyle@parisc-linux.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-arm-kernel@lists.arm.linux.org.uk \
    --cc=linux-parisc@vger.kernel.org \
    --cc=linux-pci@atrey.karlin.mff.cuni.cz \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=matthew@wil.cx \
    --cc=paulus@samba.org \
    --cc=rmk@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).