From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [patch 05/16] frv: use generic pci_enable_resources() Date: Wed, 5 Mar 2008 12:14:46 -0800 Message-ID: <20080305201446.GE13569@kroah.com> References: <20080304185820.723623873@ldl.fc.hp.com> <20080304185646.864917286@ldl.fc.hp.com> <20881.1204728766@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20881.1204728766@redhat.com> Sender: linux-parisc-owner@vger.kernel.org To: David Howells Cc: Bjorn Helgaas , Russell King , linux-arm-kernel@lists.arm.linux.org.uk, Kyle McMartin , Matthew Wilcox , Grant Grundler , linux-parisc@vger.kernel.org, Paul Mackerras , Benjamin Herrenschmidt , linuxppc-dev@ozlabs.org, Chris Zankel , linux-pci@atrey.karlin.mff.cuni.cz, linux-arch@vger.kernel.org List-Id: linux-arch.vger.kernel.org On Wed, Mar 05, 2008 at 02:52:46PM +0000, David Howells wrote: > > Bjorn Helgaas wrote: > > > Use the generic pci_enable_resources() instead of the arch-specific code. > > > > Unlike this arch-specific code, the generic version: > > - checks PCI_NUM_RESOURCES (11), not 6, resources > > - skips resources that have neither IORESOURCE_IO nor IORESOURCE_MEM set > > - skips ROM resources unless IORESOURCE_ROM_ENABLE is set > > - checks for resource collisions with "!r->parent" > > > > Signed-off-by: Bjorn Helgaas > > Acked-by: David Howells Added, thanks. greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from pentafluge.infradead.org ([213.146.154.40]:49110 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752790AbYCEURE (ORCPT ); Wed, 5 Mar 2008 15:17:04 -0500 Date: Wed, 5 Mar 2008 12:14:46 -0800 From: Greg KH Subject: Re: [patch 05/16] frv: use generic pci_enable_resources() Message-ID: <20080305201446.GE13569@kroah.com> References: <20080304185820.723623873@ldl.fc.hp.com> <20080304185646.864917286@ldl.fc.hp.com> <20881.1204728766@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20881.1204728766@redhat.com> Sender: linux-arch-owner@vger.kernel.org List-ID: To: David Howells Cc: Bjorn Helgaas , Russell King , linux-arm-kernel@lists.arm.linux.org.uk, Kyle McMartin , Matthew Wilcox , Grant Grundler , linux-parisc@vger.kernel.org, Paul Mackerras , Benjamin Herrenschmidt , linuxppc-dev@ozlabs.org, Chris Zankel , linux-pci@atrey.karlin.mff.cuni.cz, linux-arch@vger.kernel.org Message-ID: <20080305201446._o32tQKGV5WlhQ_5kNuF8Znu1b3nVyxhUce3G8B1C3Q@z> On Wed, Mar 05, 2008 at 02:52:46PM +0000, David Howells wrote: > > Bjorn Helgaas wrote: > > > Use the generic pci_enable_resources() instead of the arch-specific code. > > > > Unlike this arch-specific code, the generic version: > > - checks PCI_NUM_RESOURCES (11), not 6, resources > > - skips resources that have neither IORESOURCE_IO nor IORESOURCE_MEM set > > - skips ROM resources unless IORESOURCE_ROM_ENABLE is set > > - checks for resource collisions with "!r->parent" > > > > Signed-off-by: Bjorn Helgaas > > Acked-by: David Howells Added, thanks. greg k-h