public inbox for linux-arch@vger.kernel.org
 help / color / mirror / Atom feed
From: Nick Piggin <npiggin-l3A5Bk7waGM@public.gmane.org>
To: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
Cc: akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
	shaggy-V7BBcbaFuwjMbYB6QlFGEg@public.gmane.org,
	axboe-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org,
	linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
	linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org
Subject: Re: [patch 1/2]: x86: implement pte_special
Date: Fri, 28 Mar 2008 05:15:20 +0100	[thread overview]
Message-ID: <20080328041519.GF8083@wotan.suse.de> (raw)
In-Reply-To: <20080327.210910.101408473.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>

On Thu, Mar 27, 2008 at 09:09:10PM -0700, David Miller wrote:
> From: Nick Piggin <npiggin-l3A5Bk7waGM@public.gmane.org>
> Date: Fri, 28 Mar 2008 05:04:42 +0100
> 
> > BTW. if you are still interested, then the powerpc64 patch might be a
> > better starting point for you. I don't know how the sparc tlb flush
> > design looks like, but if it doesn't do a synchronous IPI to invalidate
> > other threads, then you can't use the x86 approach.
> 
> I have soft bits available on sparc64, that's not my issue.
> 
> My issue is that if you implemented this differently, every platform
> would get the optimization, without having to do anything special
> at all, and I think that's such a much nicer way.

Oh, they wouldn't. It is completely tied to the low level details of
their TLB and pagetable teardown design. That's the unfortunate part
about it.

The other thing is that the "how do I know if I can refcount the page
behind this (mm,vaddr,pte) tuple" can be quite arch specific as well.
And it is also non-trivial to do because that information can be dynamic
depending on what driver mapped in that given tuple.

It is *possible*, but not trivial.

WARNING: multiple messages have this Message-ID (diff)
From: Nick Piggin <npiggin@suse.de>
To: David Miller <davem@davemloft.net>
Cc: akpm@linux-foundation.org, shaggy@austin.ibm.com,
	axboe@oracle.com, linux-mm@kvack.org, linux-arch@vger.kernel.org,
	torvalds@linux-foundation.org
Subject: Re: [patch 1/2]: x86: implement pte_special
Date: Fri, 28 Mar 2008 05:15:20 +0100	[thread overview]
Message-ID: <20080328041519.GF8083@wotan.suse.de> (raw)
Message-ID: <20080328041520.mqURlMDxGj4745qVUGdvlP0BKOu_uEbEifRDvHaKWbI@z> (raw)
In-Reply-To: <20080327.210910.101408473.davem@davemloft.net>

On Thu, Mar 27, 2008 at 09:09:10PM -0700, David Miller wrote:
> From: Nick Piggin <npiggin@suse.de>
> Date: Fri, 28 Mar 2008 05:04:42 +0100
> 
> > BTW. if you are still interested, then the powerpc64 patch might be a
> > better starting point for you. I don't know how the sparc tlb flush
> > design looks like, but if it doesn't do a synchronous IPI to invalidate
> > other threads, then you can't use the x86 approach.
> 
> I have soft bits available on sparc64, that's not my issue.
> 
> My issue is that if you implemented this differently, every platform
> would get the optimization, without having to do anything special
> at all, and I think that's such a much nicer way.

Oh, they wouldn't. It is completely tied to the low level details of
their TLB and pagetable teardown design. That's the unfortunate part
about it.

The other thing is that the "how do I know if I can refcount the page
behind this (mm,vaddr,pte) tuple" can be quite arch specific as well.
And it is also non-trivial to do because that information can be dynamic
depending on what driver mapped in that given tuple.

It is *possible*, but not trivial.


  parent reply	other threads:[~2008-03-28  4:15 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-28  2:54 [patch 0/2]: lockless get_user_pages patchset Nick Piggin
2008-03-28  2:54 ` Nick Piggin
     [not found] ` <20080328025455.GA8083-B4tOwbsTzaBolqkO4TVVkw@public.gmane.org>
2008-03-28  2:55   ` [patch 1/2]: x86: implement pte_special Nick Piggin
2008-03-28  2:55     ` Nick Piggin
     [not found]     ` <20080328025541.GB8083-B4tOwbsTzaBolqkO4TVVkw@public.gmane.org>
2008-03-28  3:23       ` David Miller
2008-03-28  3:23         ` David Miller
     [not found]         ` <20080327.202334.250213398.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2008-03-28  3:31           ` Nick Piggin
2008-03-28  3:31             ` Nick Piggin
     [not found]             ` <20080328033149.GD8083-B4tOwbsTzaBolqkO4TVVkw@public.gmane.org>
2008-03-28  3:44               ` David Miller
2008-03-28  3:44                 ` David Miller
     [not found]                 ` <20080327.204431.201380891.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2008-03-28  4:04                   ` Nick Piggin
2008-03-28  4:04                     ` Nick Piggin
     [not found]                     ` <20080328040442.GE8083-B4tOwbsTzaBolqkO4TVVkw@public.gmane.org>
2008-03-28  4:09                       ` David Miller
2008-03-28  4:09                         ` David Miller
     [not found]                         ` <20080327.210910.101408473.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2008-03-28  4:15                           ` Nick Piggin [this message]
2008-03-28  4:15                             ` Nick Piggin
     [not found]                             ` <20080328041519.GF8083-B4tOwbsTzaBolqkO4TVVkw@public.gmane.org>
2008-03-28  4:16                               ` David Miller
2008-03-28  4:16                                 ` David Miller
     [not found]                                 ` <20080327.211632.02770342.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2008-03-28  4:19                                   ` Nick Piggin
2008-03-28  4:19                                     ` Nick Piggin
2008-03-28  4:17                               ` Nick Piggin
2008-03-28  4:17                                 ` Nick Piggin
2008-03-28  3:00   ` [patch 2/2]: introduce fast_gup Nick Piggin
2008-03-28  3:00     ` Nick Piggin
     [not found]     ` <20080328030023.GC8083-B4tOwbsTzaBolqkO4TVVkw@public.gmane.org>
2008-03-28 10:01       ` Jens Axboe
2008-03-28 10:01         ` Jens Axboe
2008-04-17 15:03       ` Peter Zijlstra
2008-04-17 15:03         ` Peter Zijlstra
2008-04-17 15:25         ` Linus Torvalds
2008-04-17 15:25           ` Linus Torvalds
     [not found]           ` <alpine.LFD.1.00.0804170814090.2879-5CScLwifNT1QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>
2008-04-17 16:12             ` Peter Zijlstra
2008-04-17 16:12               ` Peter Zijlstra
2008-04-17 16:18               ` Linus Torvalds
2008-04-17 16:18                 ` Linus Torvalds
     [not found]                 ` <alpine.LFD.1.00.0804170916470.2879-5CScLwifNT1QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>
2008-04-17 16:35                   ` Peter Zijlstra
2008-04-17 16:35                     ` Peter Zijlstra
2008-04-17 16:40                     ` Linus Torvalds
2008-04-17 16:40                       ` Linus Torvalds
     [not found]                       ` <alpine.LFD.1.00.0804170940270.2879-5CScLwifNT1QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>
2008-04-17 17:23                         ` Peter Zijlstra
2008-04-17 17:23                           ` Peter Zijlstra
2008-04-17 18:28                           ` Linus Torvalds
2008-04-17 18:28                             ` Linus Torvalds
     [not found]                             ` <alpine.LFD.1.00.0804171127310.2879-5CScLwifNT1QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>
2008-04-22  3:14                               ` Nick Piggin
2008-04-22  3:14                                 ` Nick Piggin
2008-04-18  6:31                           ` Geert Uytterhoeven
2008-04-18  6:31                             ` Geert Uytterhoeven
2008-04-18 14:40                             ` Linus Torvalds
2008-04-18 14:40                               ` Linus Torvalds
2008-04-18  9:58               ` Jeremy Fitzhardinge
2008-04-18  9:58                 ` Jeremy Fitzhardinge
2008-04-21 12:00             ` Avi Kivity
2008-04-21 12:00               ` Avi Kivity
     [not found]               ` <480C81C4.8030200-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2008-04-21 12:30                 ` Peter Zijlstra
2008-04-21 12:30                   ` Peter Zijlstra
2008-04-21 13:26                   ` Avi Kivity
2008-04-21 13:26                     ` Avi Kivity
     [not found]                     ` <480C9619.2050201-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2008-04-21 14:35                       ` Peter Zijlstra
2008-04-21 14:35                         ` Peter Zijlstra
2008-04-22  3:23                         ` Nick Piggin
2008-04-22  3:23                           ` Nick Piggin
     [not found]                           ` <20080422032319.GB21993-B4tOwbsTzaBolqkO4TVVkw@public.gmane.org>
2008-04-22  7:19                             ` Avi Kivity
2008-04-22  7:19                               ` Avi Kivity
2008-04-22  8:07                             ` Ingo Molnar
2008-04-22  8:07                               ` Ingo Molnar
2008-04-22  9:42       ` Peter Zijlstra
2008-04-22  9:42         ` Peter Zijlstra
2008-04-22  9:46         ` Nick Piggin
2008-04-22  9:46           ` Nick Piggin
2008-05-14 18:33           ` Dave Kleikamp
2008-05-15  1:13             ` Nick Piggin
  -- strict thread matches above, loose matches on Subject: below --
2008-05-21 11:59 [patch 1/2] x86: implement pte_special Nick Piggin
2008-05-25 14:48 Nick Piggin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080328041519.GF8083@wotan.suse.de \
    --to=npiggin-l3a5bk7wagm@public.gmane.org \
    --cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
    --cc=axboe-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
    --cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
    --cc=linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
    --cc=shaggy-V7BBcbaFuwjMbYB6QlFGEg@public.gmane.org \
    --cc=torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox