From: Matthew Wilcox <matthew-Ztpu424NOJ8@public.gmane.org>
To: Jens Axboe <jens.axboe-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Cc: "Luck, Tony" <tony.luck-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Stephen Rothwell <sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>,
linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: down_spin() implementation
Date: Fri, 28 Mar 2008 07:17:50 -0600 [thread overview]
Message-ID: <20080328131750.GT16721@parisc-linux.org> (raw)
In-Reply-To: <20080328125104.GK12346-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>
On Fri, Mar 28, 2008 at 01:51:04PM +0100, Jens Axboe wrote:
> It used to be illegal to pass flags as parameters. IIRC, sparc did some
> trickery with it. That may still be the case, I haven't checked in a
> long time.
That problem was removed before 2.6 started, iirc. At least the chapter
on 'The Fucked Up Sparc' [1] was removed before 2.6.12-rc2 (the
beginning of git history and I can't be bothered to pinpoint it more
precisely).
> Why not just fold __down_spin() into down_spin() and get rid of that
> nasty anyway?
Could have done. It's moot now that Nick's pointed out how unsafe it
is to mix down_spin() with plain down().
[1] http://www.kernel.org/pub/linux/kernel/people/rusty/kernel-locking/x467.html
--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Wilcox <matthew@wil.cx>
To: Jens Axboe <jens.axboe@oracle.com>
Cc: "Luck, Tony" <tony.luck@intel.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-arch@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: down_spin() implementation
Date: Fri, 28 Mar 2008 07:17:50 -0600 [thread overview]
Message-ID: <20080328131750.GT16721@parisc-linux.org> (raw)
Message-ID: <20080328131750.oVq7-GLigxvjcGDDgQl5JpDaUmxqnXkV0d-WfCbhA4o@z> (raw)
In-Reply-To: <20080328125104.GK12346@kernel.dk>
On Fri, Mar 28, 2008 at 01:51:04PM +0100, Jens Axboe wrote:
> It used to be illegal to pass flags as parameters. IIRC, sparc did some
> trickery with it. That may still be the case, I haven't checked in a
> long time.
That problem was removed before 2.6 started, iirc. At least the chapter
on 'The Fucked Up Sparc' [1] was removed before 2.6.12-rc2 (the
beginning of git history and I can't be bothered to pinpoint it more
precisely).
> Why not just fold __down_spin() into down_spin() and get rid of that
> nasty anyway?
Could have done. It's moot now that Nick's pointed out how unsafe it
is to mix down_spin() with plain down().
[1] http://www.kernel.org/pub/linux/kernel/people/rusty/kernel-locking/x467.html
--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
next prev parent reply other threads:[~2008-03-28 13:17 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-25 20:49 What if a TLB flush needed to sleep? Luck, Tony
2008-03-25 20:49 ` Luck, Tony
[not found] ` <1FE6DD409037234FAB833C420AA843ECE9DF60-7XlYjKTK0pM64kNsxIetb7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2008-03-25 21:47 ` Alan Cox
2008-03-25 21:47 ` Alan Cox
2008-03-26 12:32 ` Matthew Wilcox
2008-03-26 12:32 ` Matthew Wilcox
[not found] ` <20080326123239.GG16721-6jwH94ZQLHl74goWV3ctuw@public.gmane.org>
2008-03-26 20:29 ` Luck, Tony
2008-03-26 20:29 ` Luck, Tony
[not found] ` <1FE6DD409037234FAB833C420AA843ECE9EB1C-7XlYjKTK0pM64kNsxIetb7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2008-03-27 8:09 ` Jens Axboe
2008-03-27 8:09 ` Jens Axboe
2008-03-27 14:15 ` down_spin() implementation Matthew Wilcox
2008-03-27 14:15 ` Matthew Wilcox
[not found] ` <20080327141508.GL16721-6jwH94ZQLHl74goWV3ctuw@public.gmane.org>
2008-03-28 0:01 ` Nick Piggin
2008-03-28 0:01 ` Nick Piggin
[not found] ` <200803281101.25037.nickpiggin-/E1597aS9LT0CCvOHzKKcA@public.gmane.org>
2008-03-28 12:45 ` Matthew Wilcox
2008-03-28 12:45 ` Matthew Wilcox
[not found] ` <20080328124517.GQ16721-6jwH94ZQLHl74goWV3ctuw@public.gmane.org>
2008-03-28 21:16 ` Luck, Tony
2008-03-28 21:16 ` Luck, Tony
[not found] ` <1FE6DD409037234FAB833C420AA843ECF237C0-7XlYjKTK0pM64kNsxIetb7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2008-03-28 23:48 ` Arnd Bergmann
2008-03-28 23:48 ` Arnd Bergmann
2008-03-29 1:04 ` Nick Piggin
2008-03-29 1:04 ` Nick Piggin
2008-03-28 4:51 ` Stephen Rothwell
2008-03-28 4:51 ` Stephen Rothwell
[not found] ` <20080328155107.e9d8866c.sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
2008-03-28 5:03 ` Nick Piggin
2008-03-28 5:03 ` Nick Piggin
[not found] ` <200803281603.34134.nickpiggin-/E1597aS9LT0CCvOHzKKcA@public.gmane.org>
2008-03-28 12:46 ` Matthew Wilcox
2008-03-28 12:46 ` Matthew Wilcox
2008-03-28 12:51 ` Jens Axboe
2008-03-28 12:51 ` Jens Axboe
[not found] ` <20080328125104.GK12346-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>
2008-03-28 13:17 ` Matthew Wilcox [this message]
2008-03-28 13:17 ` Matthew Wilcox
[not found] ` <20080328131750.GT16721-6jwH94ZQLHl74goWV3ctuw@public.gmane.org>
2008-03-28 13:24 ` Jens Axboe
2008-03-28 13:24 ` Jens Axboe
2008-03-26 19:25 ` What if a TLB flush needed to sleep? Christoph Lameter
2008-03-26 19:25 ` Christoph Lameter
[not found] ` <Pine.LNX.4.64.0803261222090.31000-RYO/mD75kfhx2SFC9UQUAuF7EQX82lMiAL8bYrjMMd8@public.gmane.org>
2008-03-26 20:29 ` Thomas Gleixner
2008-03-26 20:29 ` Thomas Gleixner
[not found] ` <alpine.LFD.1.00.0803262121440.3781-dbfLifZv8x0yMciVaGeJ0d53zsg1cpMQ@public.gmane.org>
2008-03-27 1:19 ` Christoph Lameter
2008-03-27 1:19 ` Christoph Lameter
[not found] ` <Pine.LNX.4.64.0803261817110.1115-RYO/mD75kfhx2SFC9UQUAuF7EQX82lMiAL8bYrjMMd8@public.gmane.org>
2008-03-27 13:20 ` Peter Zijlstra
2008-03-27 13:20 ` Peter Zijlstra
2008-03-27 18:44 ` Christoph Lameter
2008-03-27 18:44 ` Christoph Lameter
[not found] ` <Pine.LNX.4.64.0803271143540.7531-RYO/mD75kfhx2SFC9UQUAuF7EQX82lMiAL8bYrjMMd8@public.gmane.org>
2008-03-28 9:59 ` Peter Zijlstra
2008-03-28 9:59 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080328131750.GT16721@parisc-linux.org \
--to=matthew-ztpu424noj8@public.gmane.org \
--cc=jens.axboe-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
--cc=sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org \
--cc=tony.luck-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox