public inbox for linux-arch@vger.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh-mnsaURCQ41sdnm+yROfE0A@public.gmane.org>
To: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: Paul Mackerras <paulus-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>,
	linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org,
	takata-TMSiXQfHlQjsTix1lMzHGQ@public.gmane.org,
	linux-m32r-rQhvJZKUsGBRYuoOT4C5/9i2O/JbrIOy@public.gmane.org,
	Linux-Arch <linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: [PATCH 1/2] Add thread_info_cache_init() to all archs
Date: Thu, 10 Apr 2008 13:22:56 +1000	[thread overview]
Message-ID: <20080410032354.90CB1DDF0F@ozlabs.org> (raw)

Some architecture need to maintain a kmem cache for thread info
structures. (next patch adds that to powerpc to fix an alignment
problem).

There is no good arch callback to use to initialize that cache
that I can find, so this adds a new one and adds an empty macro
for when it's not implemented.

Signed-off-by: Benjamin Herrenschmidt <benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
---

So we have the choice here between:

 - the ifdef on the func name that I did, consistent with what
I did before for iomap, which iirc Linus liked

 - add some more ARCH_HAS_* or HAVE_* (yuck)

 - add an empty definition to all archs .h (pain in the neck but I
can do it, though it will be an annoying patch to keep around)

 - do a weak function (will slightly bloat everybody for no good reason)

So unless there is strong complaints, I'd like to stick to my
current approach.

 include/linux/sched.h |    4 ++++
 init/main.c           |    1 +
 2 files changed, 5 insertions(+)

--- linux-work.orig/init/main.c	2008-04-10 13:11:06.000000000 +1000
+++ linux-work/init/main.c	2008-04-10 13:11:19.000000000 +1000
@@ -623,6 +623,7 @@ asmlinkage void __init start_kernel(void
 	if (efi_enabled)
 		efi_enter_virtual_mode();
 #endif
+	thread_info_cache_init();
 	fork_init(num_physpages);
 	proc_caches_init();
 	buffer_init();
Index: linux-work/include/linux/sched.h
===================================================================
--- linux-work.orig/include/linux/sched.h	2008-04-10 13:11:44.000000000 +1000
+++ linux-work/include/linux/sched.h	2008-04-10 13:12:05.000000000 +1000
@@ -1893,6 +1893,10 @@ static inline unsigned long *end_of_stac
 
 #endif
 
+#ifndef thread_info_cache_init
+#define thread_info_cache_init	do { } while(0)
+#endif
+
 /* set thread flags in other task's structures
  * - see asm/thread_info.h for TIF_xxxx flags available
  */

WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@ozlabs.org>
To: linux-kernel@vger.kernel.org
Cc: Paul Mackerras <paulus@samba.org>,
	linuxppc-dev@ozlabs.org, takata@linux-m32r.org,
	linux-m32r@ml.linux-m32r.org,
	Linux-Arch <linux-arch@vger.kernel.org>
Subject: [PATCH 1/2] Add thread_info_cache_init() to all archs
Date: Thu, 10 Apr 2008 13:22:56 +1000	[thread overview]
Message-ID: <20080410032354.90CB1DDF0F@ozlabs.org> (raw)
Message-ID: <20080410032256.jGczLDSOnJ3dTGK_AlI55S-Wh2Y3MNyu-LZrGCSXXqM@z> (raw)

Some architecture need to maintain a kmem cache for thread info
structures. (next patch adds that to powerpc to fix an alignment
problem).

There is no good arch callback to use to initialize that cache
that I can find, so this adds a new one and adds an empty macro
for when it's not implemented.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---

So we have the choice here between:

 - the ifdef on the func name that I did, consistent with what
I did before for iomap, which iirc Linus liked

 - add some more ARCH_HAS_* or HAVE_* (yuck)

 - add an empty definition to all archs .h (pain in the neck but I
can do it, though it will be an annoying patch to keep around)

 - do a weak function (will slightly bloat everybody for no good reason)

So unless there is strong complaints, I'd like to stick to my
current approach.

 include/linux/sched.h |    4 ++++
 init/main.c           |    1 +
 2 files changed, 5 insertions(+)

--- linux-work.orig/init/main.c	2008-04-10 13:11:06.000000000 +1000
+++ linux-work/init/main.c	2008-04-10 13:11:19.000000000 +1000
@@ -623,6 +623,7 @@ asmlinkage void __init start_kernel(void
 	if (efi_enabled)
 		efi_enter_virtual_mode();
 #endif
+	thread_info_cache_init();
 	fork_init(num_physpages);
 	proc_caches_init();
 	buffer_init();
Index: linux-work/include/linux/sched.h
===================================================================
--- linux-work.orig/include/linux/sched.h	2008-04-10 13:11:44.000000000 +1000
+++ linux-work/include/linux/sched.h	2008-04-10 13:12:05.000000000 +1000
@@ -1893,6 +1893,10 @@ static inline unsigned long *end_of_stac
 
 #endif
 
+#ifndef thread_info_cache_init
+#define thread_info_cache_init	do { } while(0)
+#endif
+
 /* set thread flags in other task's structures
  * - see asm/thread_info.h for TIF_xxxx flags available
  */

             reply	other threads:[~2008-04-10  3:22 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-10  3:22 Benjamin Herrenschmidt [this message]
2008-04-10  3:22 ` [PATCH 1/2] Add thread_info_cache_init() to all archs Benjamin Herrenschmidt
     [not found] ` <20080410032354.90CB1DDF0F-mnsaURCQ41sdnm+yROfE0A@public.gmane.org>
2008-04-10 21:46   ` Benjamin Herrenschmidt
2008-04-10 21:46     ` Benjamin Herrenschmidt
2008-04-14  0:19   ` Andrew Morton
2008-04-14  0:19     ` Andrew Morton
2008-04-14  0:38     ` Benjamin Herrenschmidt
2008-04-14  0:38       ` Benjamin Herrenschmidt
2008-04-14  2:13       ` Andrew Morton
2008-04-14  2:13         ` Andrew Morton
     [not found]         ` <20080413191338.9776ebd0.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2008-04-18  3:58           ` Benjamin Herrenschmidt
2008-04-18  3:58             ` Benjamin Herrenschmidt
2008-04-18  4:19             ` Andrew Morton
2008-04-18  4:19               ` Andrew Morton
     [not found]               ` <20080417211905.8ff769fa.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2008-04-18  4:38                 ` Michael Ellerman
2008-04-18  4:38                   ` Michael Ellerman
2008-04-18  6:44                 ` Benjamin Herrenschmidt
2008-04-18  6:44                   ` Benjamin Herrenschmidt
2008-05-21 17:56                   ` Benjamin Herrenschmidt
2008-05-21 17:56                     ` Benjamin Herrenschmidt
2008-05-21 18:41                     ` Andrew Morton
2008-05-21 18:41                       ` Andrew Morton
2008-05-21 19:06                       ` Sam Ravnborg
2008-05-21 20:38                         ` Benjamin Herrenschmidt
2008-05-21 20:38                           ` Benjamin Herrenschmidt
2008-05-21 19:44                       ` Benjamin Herrenschmidt
2008-05-21 19:44                         ` Benjamin Herrenschmidt
2008-05-21 20:52                         ` Andrew Morton
2008-04-18  4:21             ` Kyle McMartin
2008-04-18  4:21               ` Kyle McMartin
  -- strict thread matches above, loose matches on Subject: below --
2008-04-10 23:36 Benjamin Herrenschmidt
2008-04-10 23:36 ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080410032354.90CB1DDF0F@ozlabs.org \
    --to=benh-mnsaurcq41sdnm+yrofe0a@public.gmane.org \
    --cc=linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-m32r-rQhvJZKUsGBRYuoOT4C5/9i2O/JbrIOy@public.gmane.org \
    --cc=linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org \
    --cc=paulus-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org \
    --cc=takata-TMSiXQfHlQjsTix1lMzHGQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox