From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Axboe Subject: Re: [PATCH 1/11] Add generic helpers for arch IPI function calls Date: Tue, 22 Apr 2008 19:13:24 +0200 Message-ID: <20080422171324.GP12774@kernel.dk> References: <1208851058-8500-1-git-send-email-jens.axboe@oracle.com> <1208851058-8500-2-git-send-email-jens.axboe@oracle.com> <20080422145105.GJ12774@kernel.dk> <20080422164947.GN12774@kernel.dk> <20080422170405.GO12774@kernel.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20080422170405.GO12774-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org> Sender: linux-arch-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: To: Linus Torvalds Cc: linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, npiggin-l3A5Bk7waGM@public.gmane.org On Tue, Apr 22 2008, Jens Axboe wrote: > On Tue, Apr 22 2008, Jens Axboe wrote: > > + data = kmalloc(sizeof(*data), GFP_ATOMIC); > > + if (!unlikely(!data)) { > > Woops. I'll test everything and send out the full series, at least the > intention should have been clear. But wait, falling back to wait cannot always be safe if we are called with interrupts disabled. I don't see any way around using the global fallback for that case. -- Jens Axboe From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from brick.kernel.dk ([87.55.233.238]:6797 "EHLO kernel.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756072AbYDVRNc (ORCPT ); Tue, 22 Apr 2008 13:13:32 -0400 Date: Tue, 22 Apr 2008 19:13:24 +0200 From: Jens Axboe Subject: Re: [PATCH 1/11] Add generic helpers for arch IPI function calls Message-ID: <20080422171324.GP12774@kernel.dk> References: <1208851058-8500-1-git-send-email-jens.axboe@oracle.com> <1208851058-8500-2-git-send-email-jens.axboe@oracle.com> <20080422145105.GJ12774@kernel.dk> <20080422164947.GN12774@kernel.dk> <20080422170405.GO12774@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080422170405.GO12774@kernel.dk> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Linus Torvalds Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, npiggin@suse.de Message-ID: <20080422171324.VXKRCbEcWfvtGMforI79W6EYCbsXaGFLpAi7pGn9SpY@z> On Tue, Apr 22 2008, Jens Axboe wrote: > On Tue, Apr 22 2008, Jens Axboe wrote: > > + data = kmalloc(sizeof(*data), GFP_ATOMIC); > > + if (!unlikely(!data)) { > > Woops. I'll test everything and send out the full series, at least the > intention should have been clear. But wait, falling back to wait cannot always be safe if we are called with interrupts disabled. I don't see any way around using the global fallback for that case. -- Jens Axboe